Commit 562e8dca authored by David Tseng's avatar David Tseng Committed by Commit Bot

Restrict deps on c/p/b/tts_controller.h under chrome/browser

The intent of this change is to prevent unintended dependencies from chrome/browser -> content/public/browser/...*tts*.
Achieve this by subtracting content/public/browser/tts_controller.h from chrome/browser/DEPS; this header is the central interface for tts services. Audit existing usages.
Every such dependency should go through review from a tts owner if possible, but at least have some owner approve.

R=dmazzoni@chromium.org

Bug: 1148093

Change-Id: I25ce026ccb8b3fbc87e7d3a12237c7eb22c36f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534694
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827790}
parent 5e1db7c5
...@@ -450,6 +450,10 @@ include_rules = [ ...@@ -450,6 +450,10 @@ include_rules = [
# Should be removed once the actual network service ships. # Should be removed once the actual network service ships.
"+content/public/network", "+content/public/network",
# ASK TEXT-TO-SPEECH content/browser/speech/OWNERS BEFORE OVERRIDING THIS IN A
# SUBDIRECTORY.
"-content/public/browser/tts_controller.h",
# Other libraries. # Other libraries.
"+third_party/google_toolbox_for_mac/src", "+third_party/google_toolbox_for_mac/src",
"+third_party/icu/source/common/unicode", "+third_party/icu/source/common/unicode",
...@@ -515,4 +519,7 @@ specific_include_rules = { ...@@ -515,4 +519,7 @@ specific_include_rules = {
"chrome_content_browser_client_receiver_bindings\.cc" : [ "chrome_content_browser_client_receiver_bindings\.cc" : [
"+chrome/browser/performance_manager/mechanisms/userspace_swap_chromeos.h", "+chrome/browser/performance_manager/mechanisms/userspace_swap_chromeos.h",
], ],
"chrome_content_browser_client\.cc" : [
"+content/public/browser/tts_controller.h",
],
} }
...@@ -3,6 +3,7 @@ specific_include_rules = { ...@@ -3,6 +3,7 @@ specific_include_rules = {
"+ash/root_window_controller.h", "+ash/root_window_controller.h",
"+ash/shell.h", "+ash/shell.h",
"+ash/sticky_keys/sticky_keys_controller.h", "+ash/sticky_keys/sticky_keys_controller.h",
"+content/public/browser/tts_controller.h",
], ],
"magnification_manager\.cc": [ "magnification_manager\.cc": [
"+ash/magnifier/magnification_controller.h", "+ash/magnifier/magnification_controller.h",
...@@ -18,4 +19,7 @@ specific_include_rules = { ...@@ -18,4 +19,7 @@ specific_include_rules = {
"+ash/system/status_area_widget.h", "+ash/system/status_area_widget.h",
"+ash/system/unified/unified_system_tray.h", "+ash/system/unified/unified_system_tray.h",
], ],
"speech_monitor\.(cc|h)": [
"+content/public/browser/tts_controller.h",
],
} }
include_rules = [
"+content/public/browser/tts_controller.h",
]
include_rules = [ include_rules = [
"+chrome/services/speech/buildflags.h", "+chrome/services/speech/buildflags.h",
"+content/public/browser/tts_controller.h",
"+components/soda", "+components/soda",
"+services/network/network_context.h", "+services/network/network_context.h",
"+services/network/public/cpp" "+services/network/public/cpp"
......
specific_include_rules = {
"accessibility_controller_client\.cc": [
"+content/public/browser/tts_controller.h",
],
}
include_rules = [
"+content/public/browser/tts_controller.h",
]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment