Android: Remove unused build option "write_asset_list=true"

Has been unused for multiple years.

TBR=agrieve  # Trivial build refactor

Change-Id: I45ffeb9038896e34221569b13fe81aeec5a02eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914977
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715145}

build/android/gyp/apkbuilder.py

@@ -7,7 +7,6 @@
 """Adds the code parts to a resource APK."""
 
 import argparse
-import itertools
 import os
 import shutil
 import sys
@@ -205,12 +204,6 @@ def _AddAssets(apk, path_tuples, disable_compression=False):
                                        compress=compress)
 
 
-def _CreateAssetsList(path_tuples):
-  """Returns a newline-separated list of asset paths for the given paths."""
-  dests = sorted(t[1] for t in path_tuples)
-  return '\n'.join(dests) + '\n'
-
-
 def _AddNativeLibraries(out_apk, native_libs, android_abi, uncompress):
   """Add native libraries to APK."""
   has_crazy_linker = any(
@@ -312,10 +305,6 @@ def main(args):
           resource_apk.getinfo('AndroidManifest.xml'), out_dir=apk_manifest_dir)
 
       # 2. Assets
-      if options.write_asset_list:
-        data = _CreateAssetsList(itertools.chain(assets, uncompressed_assets))
-        build_utils.AddToZipHermetic(out_apk, 'assets/assets_list', data=data)
-
       _AddAssets(out_apk, assets, disable_compression=False)
       _AddAssets(out_apk, uncompressed_assets, disable_compression=True)
 

build/config/android/internal_rules.gni

@@ -2580,8 +2580,6 @@ if (enable_java_templates) {
   #     secondary ABI.
   #   secondary_abi_native_libs_filearg: (optional). @FileArg() of additional
   #     secondary ABI native libs.
-  #   write_asset_list: Adds an extra file to the assets, which contains a list of
-  #     all other asset files.
   #   keystore_path: Path to keystore to use for signing.
   #   keystore_name: Key alias to use.
   #   keystore_password: Keystore password.
@@ -2663,9 +2661,6 @@ if (enable_java_templates) {
         # an APK build_config.
         args += [ "--java-resources=@FileArg($_rebased_build_config:java_resources_jars)" ]
       }
-      if (defined(invoker.write_asset_list) && invoker.write_asset_list) {
-        args += [ "--write-asset-list" ]
-      }
       if (defined(invoker.dex_path)) {
         _rebased_dex_path = rebase_path(invoker.dex_path, root_build_dir)
         args += [ "--dex-file=$_rebased_dex_path" ]

build/config/android/rules.gni

@@ -2054,8 +2054,6 @@ if (enable_java_templates) {
   #     (optional).
   #   secondary_native_lib_placeholders: List of placeholder filenames to add to
   #     the apk for the secondary ABI (optional).
-  #   write_asset_list: Adds an extra file to the assets, which contains a list of
-  #     all other asset files.
   #   generate_buildconfig_java: If defined and false, skip generating the
   #     BuildConfig java class describing the build configuration. The default
   #     is true for non-test APKs.
@@ -3175,7 +3173,6 @@ if (enable_java_templates) {
                                [
                                  "native_lib_placeholders",
                                  "secondary_native_lib_placeholders",
-                                 "write_asset_list",
                                  "uncompress_dex",
                                  "uncompress_shared_libraries",
                                ])
@@ -3468,7 +3465,6 @@ if (enable_java_templates) {
                                "use_chromium_linker",
                                "version_code",
                                "version_name",
-                               "write_asset_list",
                              ])
       is_bundle_module = false
       name = invoker.apk_name
@@ -3501,7 +3497,6 @@ if (enable_java_templates) {
     if (_is_base_module) {
       assert(!defined(invoker.base_module_target))
     } else {
-      assert(!defined(invoker.write_asset_list))
       assert(!defined(invoker.app_as_shared_lib))
       assert(!defined(invoker.shared_resources))
       assert(!defined(invoker.shared_resources_whitelist_target))
@@ -3591,7 +3586,6 @@ if (enable_java_templates) {
                                "verify_manifest",
                                "version_code",
                                "version_name",
-                               "write_asset_list",
                              ])
       is_bundle_module = true
       generate_buildconfig_java = _is_base_module

testing/test.gni

@@ -102,7 +102,6 @@ template("test") {
         "target_sdk_version",
         "use_default_launcher",
         "use_native_activity",
-        "write_asset_list",
       ]
 
       # Adds the unwind tables from unstripped binary as an asset file in the