Skip to content

GitLab

T
tangled
Commit 5634066e authored by Leonard Grey's avatar Leonard Grey Committed by Commit Bot
Browse files
Options

Sheriff: Disable flaky IndexedDBDispatcherHostTest tests for all platforms 

These are currently disabled for a subset of bots but have been flaking generally:

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuUHV0V2l0aEludmFsaWRCbG9iDA
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYQsSBUZsYWtlIlZjaHJvbWl1bUBjb250ZW50X3VuaXR0ZXN0c0BJbmRleGVkREJEaXNwYXRjaGVySG9zdFRlc3QuT3Blbk5ld0Nvbm5lY3Rpb25XaGlsZVVwZ3JhZGluZww

TBR=dmurph@chromium.org

Bug: 995716, 989723
Change-Id: Ib8c97339ee28aad8c803acba47dccf10e1ec0d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822825Reviewed-by: default avatarLeonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699488}
parent 47909a58
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 14 deletions
content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
View file @ 5634066e
...@@ -347,14 +347,8 @@ TEST_F(IndexedDBDispatcherHostTest, DISABLED_CloseAfterUpgrade) { ...@@ -347,14 +347,8 @@ TEST_F(IndexedDBDispatcherHostTest, DISABLED_CloseAfterUpgrade) {
loop3.Run(); loop3.Run();
} }
// TODO(https://crbug.com/995716) Test is flaky on Mac ASan. // TODO(https://crbug.com/995716) Test is flaky on multiple platforms.
#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER) TEST_F(IndexedDBDispatcherHostTest, DISABLED_OpenNewConnectionWhileUpgrading) {
#define MAYBE_OpenNewConnectionWhileUpgrading \
DISABLED_OpenNewConnectionWhileUpgrading
#else
#define MAYBE_OpenNewConnectionWhileUpgrading OpenNewConnectionWhileUpgrading
#endif
TEST_F(IndexedDBDispatcherHostTest, MAYBE_OpenNewConnectionWhileUpgrading) {
const int64_t kDBVersion = 1; const int64_t kDBVersion = 1;
const int64_t kTransactionId = 1; const int64_t kTransactionId = 1;
const int64_t kObjectStoreId = 10; const int64_t kObjectStoreId = 10;
...@@ -454,12 +448,7 @@ MATCHER_P(IsCallbackError, error_code, "") { ...@@ -454,12 +448,7 @@ MATCHER_P(IsCallbackError, error_code, "") {
} }
// See https://crbug.com/989723 for more context, this test seems to flake. // See https://crbug.com/989723 for more context, this test seems to flake.
#if defined(OS_WIN) || (defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)) TEST_F(IndexedDBDispatcherHostTest, DISABLED_PutWithInvalidBlob) {
#define MAYBE_PutWithInvalidBlob DISABLED_PutWithInvalidBlob
#else
#define MAYBE_PutWithInvalidBlob PutWithInvalidBlob
#endif
TEST_F(IndexedDBDispatcherHostTest, MAYBE_PutWithInvalidBlob) {
const int64_t kDBVersion = 1; const int64_t kDBVersion = 1;
const int64_t kTransactionId = 1; const int64_t kTransactionId = 1;
const int64_t kObjectStoreId = 10; const int64_t kObjectStoreId = 10;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment