Commit 56484712 authored by gcasto's avatar gcasto Committed by Commit bot

[Password Manager] Widen autofill supression for testing password sites.

These sites sometimes contain "-" in addition to alpha characters.

TBR=vabr@chromium.org
BUG=415166

Review URL: https://codereview.chromium.org/605353002

Cr-Commit-Position: refs/heads/master@{#297009}
parent 9ee0c035
...@@ -492,7 +492,7 @@ bool ChromePasswordManagerClient::IsURLPasswordWebsiteReauth( ...@@ -492,7 +492,7 @@ bool ChromePasswordManagerClient::IsURLPasswordWebsiteReauth(
// All password sites, including test sites, have autofilling disabled. // All password sites, including test sites, have autofilling disabled.
CR_DEFINE_STATIC_LOCAL(RE2, account_dashboard_pattern, CR_DEFINE_STATIC_LOCAL(RE2, account_dashboard_pattern,
("passwords(-([a-z]+\\.corp))?\\.google\\.com")); ("passwords(-([a-z-]+\\.corp))?\\.google\\.com"));
return RE2::FullMatch(GURL(param_value).host(), account_dashboard_pattern); return RE2::FullMatch(GURL(param_value).host(), account_dashboard_pattern);
} }
......
...@@ -301,7 +301,7 @@ TEST_F(ChromePasswordManagerClientTest, ...@@ -301,7 +301,7 @@ TEST_F(ChromePasswordManagerClientTest,
// Make sure testing sites are disabled as well. // Make sure testing sites are disabled as well.
NavigateAndCommit( NavigateAndCommit(
GURL("https://accounts.google.com/Login?continue=" GURL("https://accounts.google.com/Login?continue="
"https://passwords-testing.corp.google.com/settings&rart=456")); "https://passwords-ac-testing.corp.google.com/settings&rart=456"));
EXPECT_FALSE(client->IsPasswordManagerEnabledForCurrentPage()); EXPECT_FALSE(client->IsPasswordManagerEnabledForCurrentPage());
// Fully qualified domain name is considered a different hostname by GURL. // Fully qualified domain name is considered a different hostname by GURL.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment