Commit 5651e583 authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot

[LayoutNG] Remove an unused member function of NGPhysicalLineBoxFragment

The function is unused after crrev.com/c/1000952. It's also a bad-designed
function due to the requirement of a seemingly redundant parameter.

Hence, this patch removes it.

Bug: 822575
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iefdc4a9f6cde0d8f5edfc6d4c75750b1655f6c39
Reviewed-on: https://chromium-review.googlesource.com/1007973Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550241}
parent 0dc3d913
......@@ -87,14 +87,6 @@ bool NGPhysicalLineBoxFragment::HasSoftWrapToNextLine() const {
return !break_token.IsFinished() && !break_token.IsForcedBreak();
}
// TODO(xiaochengh): Try avoid passing |previous_line|.
bool NGPhysicalLineBoxFragment::HasSoftWrapFromPreviousLine(
const NGPhysicalLineBoxFragment* previous_line) const {
if (!previous_line)
return false;
return previous_line->HasSoftWrapToNextLine();
}
PositionWithAffinity NGPhysicalLineBoxFragment::PositionForPoint(
const NGPhysicalOffset& point) const {
return PositionForPointInInlineLevelBox(point);
......
......@@ -47,10 +47,6 @@ class CORE_EXPORT NGPhysicalLineBoxFragment final
// Whether the content soft-wraps to the next line.
bool HasSoftWrapToNextLine() const;
// Whether the content is following a soft-wrap from the previous line.
// TODO(xiaochengh): Try to avoid passing the previous line.
bool HasSoftWrapFromPreviousLine(const NGPhysicalLineBoxFragment*) const;
PositionWithAffinity PositionForPoint(const NGPhysicalOffset&) const final;
scoped_refptr<NGPhysicalFragment> CloneWithoutOffset() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment