Skip to content

GitLab

T
tangled
Commit 5658a622 authored by Matt Jones's avatar Matt Jones Committed by Commit Bot
Browse files
Options

Fix selection flake in TabsTest 

TabsTests are almost completely deflaked with the exception of text
occasionally be incorrectly selected in
testTabSwitcherCollapseSelection. This speculative fix will hopefully
deflake by scrolling the correct direction in the test and above what
should be empty space on the web page and adding arbitrarily long
content area to scroll on. Flakes can be found here:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTabSwitcherCollapseSelection

Bug: 799728
Change-Id: I47eb6e9e5439fe545d71889a75886fdee2edf618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334821Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794239}
parent 9b91e926
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 3 deletions
chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
View file @ 5658a622
......@@ -390,7 +390,7 @@ public class TabsTest {
}
private void scrollDown() {
fling(0.f, 0.5f, 0.f, 0.75f, 100);
fling(0.f, 0.9f, 0.f, 0.1f, 100);
}
/**
......
chrome/test/data/android/tabstest/tabs_test.html
View file @ 5658a622
......@@ -3,11 +3,11 @@
<meta name="viewport" content="width=device-width" />
<title>Data file for TabsTest</title>
</head>
<body>
<body style="display: block; height: 2000px;">
<textarea id="textarea" rows="4" cols="10">helloworld</textarea>
<button type="button" id="button" onclick='window.open("about:blank");'>Click me!</button>
<br>
<input type="text" id="input_text"></input>
Data file for TabsTest.
</body>
</html>
\ No newline at end of file
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment