Commit 5665173d authored by Sahel Sharify's avatar Sahel Sharify Committed by Commit Bot

Use of dump without crashing to debug smooth scroll animation bug.

Bug: 797708
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icce9d0c3eeed94297936aebc81681f5db2ec0682
Reviewed-on: https://chromium-review.googlesource.com/1226825Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591377}
parent 6b20212b
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/containers/adapters.h" #include "base/containers/adapters.h"
#include "base/containers/flat_map.h" #include "base/containers/flat_map.h"
#include "base/debug/dump_without_crashing.h"
#include "base/json/json_writer.h" #include "base/json/json_writer.h"
#include "base/memory/memory_coordinator_client_registry.h" #include "base/memory/memory_coordinator_client_registry.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
...@@ -3824,14 +3825,14 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollAnimated( ...@@ -3824,14 +3825,14 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollAnimated(
scroll_status.thread = SCROLL_IGNORED; scroll_status.thread = SCROLL_IGNORED;
scroll_status.main_thread_scrolling_reasons = scroll_status.main_thread_scrolling_reasons =
MainThreadScrollingReason::kNotScrollable; MainThreadScrollingReason::kNotScrollable;
// Adding NOTREACHED to debug https://crbug.com/797708, based on the // Dump without crashing to debug https://crbug.com/797708, based on the
// traces on the bug scrolling gets stuck in a situation where the // traces on the bug scrolling gets stuck in a situation where the
// layout_tree_host_impl assumes that there is an ongoing scroll animation // layout_tree_host_impl assumes that there is an ongoing scroll animation
// since scroll_node exists but the // since scroll_node exists but the
// ScrollOffsetAnimationsImpl::ScrollAnimationUpdateTarget returns false // ScrollOffsetAnimationsImpl::ScrollAnimationUpdateTarget returns false
// since no keyframe_model exists. TODO(sahel):remove this once the issue // since no keyframe_model exists. TODO(sahel):remove this once the issue
// is fixed. // is fixed.
NOTREACHED(); base::debug::DumpWithoutCrashing();
} }
return scroll_status; return scroll_status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment