WebShare: IsDangerousFilename ignores case

Bug: 1035527
Change-Id: I01684142f18665a83bd5b0e1f74de97cf64c90bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392029
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804821}

chrome/browser/webshare/share_service_impl.cc

@@ -79,10 +79,8 @@ bool ShareServiceImpl::IsDangerousFilename(base::StringPiece name) {
       ".xbm",    // image/x-xbitmap
   };
 
-  const std::string lower_name = base::ToLowerASCII(name);
-
   for (const char* permitted : kPermitted) {
-    if (base::EndsWith(lower_name, permitted))
+    if (base::EndsWith(name, permitted, base::CompareCase::INSENSITIVE_ASCII))
       return false;
   }
   return true;

chrome/browser/webshare/share_service_unittest.cc

@@ -104,6 +104,11 @@ TEST_F(ShareServiceUnitTest, DangerousFilename) {
 
   EXPECT_TRUE(ShareServiceImpl::IsDangerousFilename("a/a"));
   EXPECT_TRUE(ShareServiceImpl::IsDangerousFilename("zzz/zzz"));
+
+  EXPECT_FALSE(ShareServiceImpl::IsDangerousFilename("1.XBM"));
+  EXPECT_FALSE(ShareServiceImpl::IsDangerousFilename("2.bMP"));
+  EXPECT_FALSE(ShareServiceImpl::IsDangerousFilename("3.Flac"));
+  EXPECT_FALSE(ShareServiceImpl::IsDangerousFilename("4.webM"));
 }
 
 TEST_F(ShareServiceUnitTest, DangerousMimeType) {
@@ -112,6 +117,9 @@ TEST_F(ShareServiceUnitTest, DangerousMimeType) {
 
   EXPECT_TRUE(ShareServiceImpl::IsDangerousMimeType("a/a"));
   EXPECT_TRUE(ShareServiceImpl::IsDangerousMimeType("zzz/zzz"));
+
+  EXPECT_TRUE(ShareServiceImpl::IsDangerousMimeType("audio/Flac"));
+  EXPECT_TRUE(ShareServiceImpl::IsDangerousMimeType("Video/webm"));
 }
 
 TEST_F(ShareServiceUnitTest, Multimedia) {