Skip to content

GitLab

T
tangled
Commit 56779779 authored by Mike West's avatar Mike West Committed by Commit Bot
Browse files
Options

Remove 'cookies/secure/create-cookie-http.html' 

This test is broken; every browser fails it in the same way, and the
thing it actually intends to cover is addressed by the other six tests
in https://wpt.fyi/results/cookies/secure.

Change-Id: Ib7b8534b35ae16490f2cf71e67936b5636e33fbe
Reviewed-on: https://chromium-review.googlesource.com/1196544Reviewed-by: default avatarFriedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587535}
parent 36788839
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 43 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 56779779
......@@ -4290,7 +4290,6 @@ crbug.com/843945 external/wpt/cookies/samesite/iframe.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/img.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/window-open-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/window-open.html [ Failure ]
crbug.com/843945 external/wpt/cookies/secure/create-cookie-http.html [ Failure ]
# Client hint tests that fail in content_shell but pass when run manually using
# full browser.
......
third_party/WebKit/LayoutTests/external/wpt/cookies/secure/create-cookie-http-expected.txt deleted 100644 → 0
View file @ 36788839
This is a testharness.js-based test.
FAIL Secure cookies cannot be set by insecure origins assert_equals: Insecure cookies are always present expected "0.2512442783278579" but got ""
Harness: the test ran to completion.
third_party/WebKit/LayoutTests/external/wpt/cookies/secure/create-cookie-http.html deleted 100644 → 0
View file @ 36788839
<!DOCTYPE html>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/cookies/resources/cookie-helper.sub.js"></script>
<script>
//origin is who sets the cookie
//target is who tries to send cookie
function create_test(origin, target, expectedStatus, title) {
promise_test(t => {
var value = "" + Math.random();
return resetSecureCookies(origin, value)
.then(_ => {
return credFetch(target + "/cookies/resources/list.py")
.then(r => r.json())
.then(cookies => verifySecureCookieState(expectedStatus, value, cookies));
});
}, title);
}
//Given an |expectedStatus| and |expectedValue|, assert the |cookies| contains the
//proper set of cookie names and values.
function verifySecureCookieState(expectedStatus, expectedValue, cookies) {
assert_equals(cookies["alone_insecure"], expectedValue, "Insecure cookies are always present");
if (expectedStatus == SecureStatus.INSECURE_COOKIE_ONLY) {
assert_equals(cookies["alone_secure"], undefined, "Secure cookies are not present");
} else if (expectedStatus == SecureStatus.BOTH_COOKIES) {
assert_equals(cookies["alone_secure"], expectedValue, "Secure cookies are present");
}
}
//cookies set by insecure origins
create_test(INSECURE_ORIGIN, INSECURE_ORIGIN, SecureStatus.INSECURE_COOKIE_ONLY, "Secure cookies cannot be set by insecure origins");
//create_test(INSECURE_ORIGIN, SECURE_ORIGIN, SecureStatus.INSECURE_COOKIE_ONLY, "Secure cookies cannot be set by insecure origins, even if read from a secure origin");
//This test should set the secure cookie right but not be able to read it from the secure origin
//create_test(SECURE_ORIGIN, INSECURE_ORIGIN, SecureStatus.INSECURE_COOKIE_ONLY, "Secure cookies should not be read by insecure origins");
//create_test(SECURE_ORIGIN, SECURE_ORIGIN, SecureStatus.BOTH_COOKIES, "Secure cookies should be set and read by secure domains")
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment