Turn on surface sync with --enable-viz.

Always turn on surface synchronization when the --enable-viz flag is
present. Disable a few extra tests which now fail in the new
configuration.

The --enable-surface-synchronization flag was added to an FYI trybot to
check for failures. No failures were observed over the weekend. Remove
the now unneeded flag from the FYI trybot.

Bug: 793302
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6bc0aff21d968ba5ee38f7453fbd7b5779efb34a
Reviewed-on: https://chromium-review.googlesource.com/812409
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523685}

components/viz/common/features.cc

@@ -14,9 +14,10 @@ const base::Feature kEnableSurfaceSynchronization{
     "SurfaceSynchronization", base::FEATURE_DISABLED_BY_DEFAULT};
 
 bool IsSurfaceSynchronizationEnabled() {
+  auto* command_line = base::CommandLine::ForCurrentProcess();
   return base::FeatureList::IsEnabled(kEnableSurfaceSynchronization) ||
-         base::CommandLine::ForCurrentProcess()->HasSwitch(
-             switches::kEnableSurfaceSynchronization);
+         command_line->HasSwitch(switches::kEnableSurfaceSynchronization) ||
+         command_line->HasSwitch(switches::kEnableViz);
 }
 
 }  // namespace features

testing/buildbot/chromium.fyi.json

@@ -4304,7 +4304,6 @@
       },
       {
         "args": [
-          "--enable-surface-synchronization",
           "--enable-viz",
           "--test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter"
         ],

testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

@@ -101,7 +101,10 @@
 -ScreenOrientationOOPIFBrowserTest.ScreenOrientation
 -ScreenOrientationOOPIFBrowserTest.ScreenOrientationInPendingMainFrame
 -SitePerProcessBrowserTest.CommunicateWithProxyAfterCancelPending
+-SitePerProcessBrowserTest.CrossProcessInertSubframe
 -SitePerProcessBrowserTest.CrossSiteIframeDisplayNone
+-SitePerProcessBrowserTest.FileChooserInSubframe
+-SitePerProcessBrowserTest.MainframeTouchEventRouting
 -SitePerProcessBrowserTest.RecreateMainFrameAfterCancelPending
 -SitePerProcessBrowserTest.ReuseNonLiveRenderViewHostAfterCancelPending
 -WheelScrollLatchingBrowserTest.WheelEventTarget

testing/buildbot/filters/viz.content_browsertests.filter

@@ -91,3 +91,21 @@
 
 # TODO: investigate flaky failure http://crbug.com/792740
 -IsolatedOriginTest.ProcessLimit
+
+# Tests failures related to surface sync. http://crbug.com/793302
+-RenderWidgetHostViewBrowserTestBase.CompositorWorksWhenReusingRenderer
+-RenderWidgetInitialSizeTest.InitialSize
+-RenderWidgetTest.OnResize
+-ScreenOrientationBrowserTest.ScreenOrientationChange
+-ScreenOrientationBrowserTest.WindowOrientationChange
+-ScreenOrientationOOPIFBrowserTest.ScreenOrientation
+-ScreenOrientationOOPIFBrowserTest.ScreenOrientationInPendingMainFrame
+-SitePerProcessBrowserTest.CommunicateWithProxyAfterCancelPending
+-SitePerProcessBrowserTest.CrossProcessInertSubframe
+-SitePerProcessBrowserTest.CrossSiteIframeDisplayNone
+-SitePerProcessBrowserTest.FileChooserInSubframe
+-SitePerProcessBrowserTest.MainframeTouchEventRouting
+-SitePerProcessBrowserTest.RecreateMainFrameAfterCancelPending
+-SitePerProcessBrowserTest.ReuseNonLiveRenderViewHostAfterCancelPending
+-WheelScrollLatchingBrowserTest.WheelEventTarget
+-WheelScrollLatchingDisabledBrowserTest.WheelEventTarget

testing/buildbot/test_suites.pyl

@@ -1254,7 +1254,6 @@
   'mojo_chromiumos_specific_gtests': {
     'viz_content_browsertests': {
       'args': [
-        '--enable-surface-synchronization',
         '--enable-viz',
         '--test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter',
       ],