Commit 569f791a authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

History WebUI: add title for actions menu

Bug: 867065
Change-Id: I05f3b8c4c1f313fa203302a0a27da5b002cedfe0
Reviewed-on: https://chromium-review.googlesource.com/c/1309219Reviewed-by: default avatarcalamity <calamity@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606334}
parent 1f825a65
...@@ -211,7 +211,7 @@ ...@@ -211,7 +211,7 @@
<paper-icon-button-light id="menu-button-container" <paper-icon-button-light id="menu-button-container"
class="more-vert-button"> class="more-vert-button">
<button id="menu-button" <button id="menu-button"
title="$i18n{moreActionsButton}" on-click="onMenuButtonTap_"> title="$i18n{actionMenuDescription}" on-click="onMenuButtonTap_">
<div></div> <div></div>
<div></div> <div></div>
<div></div> <div></div>
......
...@@ -77,7 +77,7 @@ ...@@ -77,7 +77,7 @@
<cr-lazy-render id="sharedMenu"> <cr-lazy-render id="sharedMenu">
<template> <template>
<cr-action-menu> <cr-action-menu aria-label="$i18n{actionMenuDescription}">
<button id="menuMoreButton" slot="item" class="dropdown-item" <button id="menuMoreButton" slot="item" class="dropdown-item"
hidden="[[!canSearchMoreFromSite_( hidden="[[!canSearchMoreFromSite_(
searchedTerm, actionMenuModel_.item.domain)]]" searchedTerm, actionMenuModel_.item.domain)]]"
......
...@@ -87,8 +87,8 @@ ...@@ -87,8 +87,8 @@
</div> </div>
<div id="right-buttons"> <div id="right-buttons">
<paper-icon-button-light class="more-vert-button"> <paper-icon-button-light class="more-vert-button">
<button id="menu-button" <button id="menu-button" on-click="onMenuButtonTap_"
on-click="onMenuButtonTap_" title="$i18n{moreActionsButton}"> title="$i18n{actionMenuDescription}">
<div></div> <div></div>
<div></div> <div></div>
<div></div> <div></div>
......
...@@ -55,6 +55,8 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile, ...@@ -55,6 +55,8 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile,
content::WebUIDataSource::Create(chrome::kChromeUIHistoryHost); content::WebUIDataSource::Create(chrome::kChromeUIHistoryHost);
// Localized strings (alphabetical order). // Localized strings (alphabetical order).
source->AddLocalizedString("actionMenuDescription",
IDS_HISTORY_ACTION_MENU_DESCRIPTION);
source->AddLocalizedString("bookmarked", IDS_HISTORY_ENTRY_BOOKMARKED); source->AddLocalizedString("bookmarked", IDS_HISTORY_ENTRY_BOOKMARKED);
source->AddLocalizedString("cancel", IDS_CANCEL); source->AddLocalizedString("cancel", IDS_CANCEL);
source->AddLocalizedString("clearBrowsingData", source->AddLocalizedString("clearBrowsingData",
...@@ -82,8 +84,6 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile, ...@@ -82,8 +84,6 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile,
source->AddLocalizedString("itemsSelected", IDS_MD_HISTORY_ITEMS_SELECTED); source->AddLocalizedString("itemsSelected", IDS_MD_HISTORY_ITEMS_SELECTED);
source->AddLocalizedString("loading", IDS_HISTORY_LOADING); source->AddLocalizedString("loading", IDS_HISTORY_LOADING);
source->AddLocalizedString("menuPromo", IDS_MD_HISTORY_MENU_PROMO); source->AddLocalizedString("menuPromo", IDS_MD_HISTORY_MENU_PROMO);
source->AddLocalizedString("moreActionsButton",
IDS_HISTORY_ACTION_MENU_DESCRIPTION);
source->AddLocalizedString("moreFromSite", IDS_HISTORY_MORE_FROM_SITE); source->AddLocalizedString("moreFromSite", IDS_HISTORY_MORE_FROM_SITE);
source->AddLocalizedString("openAll", IDS_HISTORY_OTHER_SESSIONS_OPEN_ALL); source->AddLocalizedString("openAll", IDS_HISTORY_OTHER_SESSIONS_OPEN_ALL);
source->AddLocalizedString("openTabsMenuItem", source->AddLocalizedString("openTabsMenuItem",
......
...@@ -60,8 +60,9 @@ ...@@ -60,8 +60,9 @@
outline: none; outline: none;
} }
</style> </style>
<dialog id="dialog" tabindex="0" on-close="onNativeDialogClose_"> <dialog id="dialog" tabindex="0" on-close="onNativeDialogClose_" role="menu"
<div class="item-wrapper" tabindex="-1" role="menu"> aria-label$="[[ariaLabel]]">
<div class="item-wrapper" tabindex="-1">
<slot name="item" id="contentNode"></slot> <slot name="item" id="contentNode"></slot>
</div> </div>
</dialog> </dialog>
......
...@@ -157,6 +157,8 @@ Polymer({ ...@@ -157,6 +157,8 @@ Polymer({
type: Boolean, type: Boolean,
value: false, value: false,
}, },
ariaLabel: String,
}, },
listeners: { listeners: {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment