Commit 56b835c7 authored by Lijin Shen's avatar Lijin Shen Committed by Commit Bot

Fix missing tick mark on language list

1. The language is not properly set as blocked.
2. Re-generate the list items after click actions to toggle
the tick mark.

Bug: 1057051
Change-Id: I860a3224b72f00badd1c5509086aa892a33cdf7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080447Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745629}
parent 4c6d3365
......@@ -88,7 +88,7 @@ public class LanguageListPreference extends Preference {
int textId = model.get(ListMenuItemProperties.TITLE_ID);
if (textId == R.string.languages_item_option_offer_to_translate) {
// Toggle current blocked state of this language.
boolean state = model.get(ListMenuItemProperties.MENU_ITEM_ID) != 0;
boolean state = model.get(ListMenuItemProperties.END_ICON_ID) == 0;
TranslateBridge.setLanguageBlockedState(info.getCode(), !state);
LanguagesManager.recordAction(state
? LanguagesManager.LanguageSettingsActionType
......@@ -107,6 +107,10 @@ public class LanguageListPreference extends Preference {
LanguagesManager.getInstance().moveLanguagePosition(
info.getCode(), -position, true);
}
// Re-generate list items.
if (textId != R.string.remove) {
notifyDataSetChanged();
}
};
((LanguageRowViewHolder) holder)
.setMenuButtonDelegate(() -> new BasicListMenu(mContext, menuItems, delegate));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment