Commit 56cd8570 authored by Ayu Ishii's avatar Ayu Ishii Committed by Commit Bot

CookieStore: Update TaskType to DOMManipulation

This change updates TaskType to match the spec from
kMiscPlatformAPI to kDOMManipulation. Further
discussion can be found here:
https://github.com/WICG/cookie-store/issues/159

Bug: 1128057
Change-Id: Ic1066280d7810328f70881772d51066f852b1803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412699Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807241}
parent 9c698161
......@@ -515,7 +515,7 @@ void CookieStore::StartObserving() {
// See https://bit.ly/2S0zRAS for task types.
auto task_runner =
GetExecutionContext()->GetTaskRunner(TaskType::kMiscPlatformAPI);
GetExecutionContext()->GetTaskRunner(TaskType::kDOMManipulation);
backend_->AddChangeListener(
default_cookie_url_, default_site_for_cookies_, default_top_frame_origin_,
change_listener_receiver_.BindNewPipeAndPassRemote(task_runner), {});
......
......@@ -52,7 +52,7 @@ class GlobalCookieStoreImpl final
mojo::Remote<network::mojom::blink::RestrictedCookieManager> backend;
execution_context->GetBrowserInterfaceBroker().GetInterface(
backend.BindNewPipeAndPassReceiver(
execution_context->GetTaskRunner(TaskType::kMiscPlatformAPI)));
execution_context->GetTaskRunner(TaskType::kDOMManipulation)));
cookie_store_ = MakeGarbageCollected<CookieStore>(execution_context,
std::move(backend));
}
......
......@@ -55,11 +55,9 @@ class ServiceWorkerRegistrationCookiesImpl final
HeapMojoRemote<mojom::blink::CookieStore,
HeapMojoWrapperMode::kWithoutContextObserver>
backend(execution_context);
// TODO(pwnall): Replace TaskType::kInternalDefault with the task queue in
// the Cookie Store spec, once that spec is finalized.
execution_context->GetBrowserInterfaceBroker().GetInterface(
backend.BindNewPipeAndPassReceiver(
execution_context->GetTaskRunner(TaskType::kInternalDefault)));
execution_context->GetTaskRunner(TaskType::kDOMManipulation)));
cookie_store_manager_ = MakeGarbageCollected<CookieStoreManager>(
registration_, std::move(backend));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment