Removing the UsePdfCompositorServiceName feature.

The default state of the UsePdfCompositorServiceName has no impact
on the condition that refers to this feature in
CreateCompositeClientIfNeeded in
//components/printing/browser/print_manager_utils.cc:

- On desktop, the feature is always enabled, but this is not important
  since ShouldPdfCompositorBeEnabledForOopifs will return true on
  desktop because of UseDedicatedProcessesForAllSites.

- On Android the feature is always disabled, so there is no point
  in consulting the feature from ShouldPdfCompositorBeEnabledForOopifs.

Bug: 824867
Change-Id: I15790906a0c124571dba79e2c02f1c6a68aff935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864010Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708103}

chrome/browser/about_flags.cc

@@ -3256,11 +3256,6 @@ const FeatureEntry kFeatureEntries[] = {
 #endif  // BUILDFLAG(ENABLE_PDF)
 
 #if BUILDFLAG(ENABLE_PRINTING)
-    {"use-pdf-compositor-service-for-print",
-     flag_descriptions::kUsePdfCompositorServiceName,
-     flag_descriptions::kUsePdfCompositorServiceDescription, kOsAll,
-     FEATURE_VALUE_TYPE(printing::features::kUsePdfCompositorServiceForPrint)},
-
     {"harfbuzz-pdf-subsetter", flag_descriptions::kHarfBuzzPDFSubsetterName,
      flag_descriptions::kHarfBuzzPDFSubsetterDescription, kOsAll,
      FEATURE_VALUE_TYPE(printing::features::kHarfBuzzPDFSubsetter)},

chrome/browser/flag_descriptions.cc

@@ -2187,14 +2187,6 @@ const char kUnsafeWebGPUDescription[] =
 const char kUiPartialSwapName[] = "Partial swap";
 const char kUiPartialSwapDescription[] = "Sets partial swap behavior.";
 
-const char kUsePdfCompositorServiceName[] =
-    "Use PDF compositor service for printing";
-const char kUsePdfCompositorServiceDescription[] =
-    "When enabled, use PDF compositor service to composite and generate PDF "
-    "files for printing. When site isolation is enabled, disabling this will "
-    "not stop using PDF compositor service since the service is required for "
-    "printing out-of-process iframes correctly.";
-
 const char kUserActivationV2Name[] = "User Activation v2";
 const char kUserActivationV2Description[] =
     "Enable simple user activation for APIs that are otherwise controlled by "

chrome/browser/flag_descriptions.h

@@ -1282,9 +1282,6 @@ extern const char kUnsafeWebGPUDescription[];
 extern const char kUiPartialSwapName[];
 extern const char kUiPartialSwapDescription[];
 
-extern const char kUsePdfCompositorServiceName[];
-extern const char kUsePdfCompositorServiceDescription[];
-
 extern const char kUserActivationV2Name[];
 extern const char kUserActivationV2Description[];
 

components/printing/browser/features.cc

@@ -7,14 +7,6 @@
 namespace printing {
 namespace features {
 
-#if defined(OS_ANDROID)
-const base::Feature kUsePdfCompositorServiceForPrint{
-    "UsePdfCompositorServiceForPrint", base::FEATURE_DISABLED_BY_DEFAULT};
-#else
-const base::Feature kUsePdfCompositorServiceForPrint{
-    "UsePdfCompositorServiceForPrint", base::FEATURE_ENABLED_BY_DEFAULT};
-#endif
-
 #if defined(OS_MACOSX)
 const base::Feature kEnableCustomMacPaperSizes{
     "EnableCustomMacPaperSizes", base::FEATURE_DISABLED_BY_DEFAULT};

components/printing/browser/features.h

@@ -11,9 +11,6 @@
 namespace printing {
 namespace features {
 
-// Use pdf compositor service to generate PDF files for printing.
-extern const base::Feature kUsePdfCompositorServiceForPrint;
-
 #if defined(OS_MACOSX)
 extern const base::Feature kEnableCustomMacPaperSizes;
 #endif

components/printing/browser/print_manager_utils.cc

@@ -4,7 +4,6 @@
 
 #include "components/printing/browser/print_manager_utils.h"
 
-#include "components/printing/browser/features.h"
 #include "components/printing/browser/print_composite_client.h"
 #include "components/printing/common/print_messages.h"
 #include "content/public/browser/site_isolation_policy.h"
@@ -36,9 +35,7 @@ void CreateCompositeClientIfNeeded(content::WebContents* web_contents,
   // where OOPIF is used such as isolate-extensions, but should be good for
   // feature testing purpose. Eventually, we will remove this check and use pdf
   // compositor service by default for printing.
-  if (content::SiteIsolationPolicy::ShouldPdfCompositorBeEnabledForOopifs() ||
-      base::FeatureList::IsEnabled(
-          features::kUsePdfCompositorServiceForPrint)) {
+  if (content::SiteIsolationPolicy::ShouldPdfCompositorBeEnabledForOopifs()) {
     PrintCompositeClient::CreateForWebContents(web_contents);
     PrintCompositeClient::FromWebContents(web_contents)
         ->SetUserAgent(user_agent);

testing/variations/fieldtrial_testing_config.json

@@ -6501,24 +6501,6 @@
             ]
         }
     ],
-    "UsePdfCompositorServiceForPrint": [
-        {
-            "platforms": [
-                "chromeos",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "UsePdfCompositorServiceForPrint",
-                    "enable_features": [
-                        "UsePdfCompositorServiceForPrint"
-                    ]
-                }
-            ]
-        }
-    ],
     "UseSkiaRenderer": [
         {
             "platforms": [