Skip to content

GitLab

T
tangled
Commit 57007114 authored by Tatiana Buldina's avatar Tatiana Buldina Committed by Commit Bot
Browse files
Options

[ChromeDriver] Remove invalid test 

This particular test expects ChromeDriver to wait for an extension iframe to load.
ChromeDriver has already been modified by r670576 to not automatically wait for iframe load,
so this test is no longer valid.

Bug: chromedriver:2965
Change-Id: I4f1227c0b2ad27c63f6e8b1614914be24a63528b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787167Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694270}
parent 37cff53d
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 18 deletions
chrome/test/chromedriver/test/run_py_tests.py
View file @ 57007114
...@@ -78,8 +78,6 @@ _NEGATIVE_FILTER = [ ...@@ -78,8 +78,6 @@ _NEGATIVE_FILTER = [
'ChromeDriverTest.testAlertOnNewWindow', 'ChromeDriverTest.testAlertOnNewWindow',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2532 # https://bugs.chromium.org/p/chromedriver/issues/detail?id=2532
'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout', 'ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2965
'ChromeExtensionsCapabilityTest.testWaitsForExtensionToLoad'
] ]
...@@ -3321,22 +3319,6 @@ class ChromeExtensionsCapabilityTest(ChromeDriverBaseTestWithWebServer): ...@@ -3321,22 +3319,6 @@ class ChromeExtensionsCapabilityTest(ChromeDriverBaseTestWithWebServer):
zip_1 = os.path.join(_TEST_DATA_DIR, 'ext_test_1.zip') zip_1 = os.path.join(_TEST_DATA_DIR, 'ext_test_1.zip')
self.CreateDriver(chrome_extensions=[self._PackExtension(zip_1)]) self.CreateDriver(chrome_extensions=[self._PackExtension(zip_1)])
def testWaitsForExtensionToLoad(self):
did_load_event = threading.Event()
def RunServer():
time.sleep(5)
self._sync_server.RespondWithContent('<html>iframe</html>')
did_load_event.set()
thread = threading.Thread(target=RunServer)
thread.daemon = True
thread.start()
crx = os.path.join(_TEST_DATA_DIR, 'ext_slow_loader.crx')
driver = self.CreateDriver(
chrome_switches=['user-agent=' + self._sync_server.GetUrl()],
chrome_extensions=[self._PackExtension(crx)])
self.assertTrue(did_load_event.is_set())
def testCanLaunchApp(self): def testCanLaunchApp(self):
app_path = os.path.join(_TEST_DATA_DIR, 'test_app') app_path = os.path.join(_TEST_DATA_DIR, 'test_app')
driver = self.CreateDriver(chrome_switches=['load-extension=%s' % app_path]) driver = self.CreateDriver(chrome_switches=['load-extension=%s' % app_path])
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment