Commit 57064b0b authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

Re-enable ShareDialog/FileManagerBrowserTest.Test/* all bots.

After crrev.com/552575 tests in test extension testcase namespace must
be anon Function so the test case name is shown on success/failure, so
change the ShareDialog testcase code to conform to that rule.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib152ff792837cd21420eed6b9918e15d03f6f95c
Reviewed-on: https://chromium-review.googlesource.com/1029394Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553975}
parent 3c230357
...@@ -286,13 +286,8 @@ WRAPPED_INSTANTIATE_TEST_CASE_P( ...@@ -286,13 +286,8 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
TestParameter(IN_GUEST_MODE, "restoreCurrentView"), TestParameter(IN_GUEST_MODE, "restoreCurrentView"),
TestParameter(NOT_IN_GUEST_MODE, "restoreCurrentView"))); TestParameter(NOT_IN_GUEST_MODE, "restoreCurrentView")));
#if defined(DISABLE_SLOW_FILESAPP_TESTS)
#define MAYBE_ShareDialog DISABLED_ShareDialog
#else
#define MAYBE_ShareDialog ShareDialog
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P( WRAPPED_INSTANTIATE_TEST_CASE_P(
DISABLED_ShareDialog, ShareDialog,
FileManagerBrowserTest, FileManagerBrowserTest,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "shareFile"), ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "shareFile"),
TestParameter(NOT_IN_GUEST_MODE, "shareDirectory"))); TestParameter(NOT_IN_GUEST_MODE, "shareDirectory")));
......
...@@ -106,11 +106,15 @@ function share(path) { ...@@ -106,11 +106,15 @@ function share(path) {
} }
/** /**
* Tests sharing a file on Drive * Tests sharing a file on Drive.
*/ */
testcase.shareFile = share.bind(null, 'world.ogv'); testcase.shareFile = function() {
share('world.ogv');
};
/** /**
* Tests sharing a directory on Drive * Tests sharing a directory on Drive.
*/ */
testcase.shareDirectory = share.bind(null, 'photos'); testcase.shareDirectory = function() {
share('photos');
};
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment