Commit 57310ced authored by agrieve's avatar agrieve Committed by Commit bot

Remove dependency on GYP_DEFINES in clang gclient hook

The gold plugin is needed only for linux official builds. However, since
it's only 17MB, it's better to always download it rather than having it
depend on GYP_DEFINES.

BUG=570091, 699210

Review-Url: https://codereview.chromium.org/2733043002
Cr-Commit-Position: refs/heads/master@{#455991}
parent 3c0495f5
...@@ -397,9 +397,8 @@ def VeryifyVersionOfBuiltClangMatchesVERSION(): ...@@ -397,9 +397,8 @@ def VeryifyVersionOfBuiltClangMatchesVERSION():
def UpdateClang(args): def UpdateClang(args):
print 'Updating Clang to %s...' % PACKAGE_VERSION print 'Updating Clang to %s...' % PACKAGE_VERSION
need_gold_plugin = 'LLVM_DOWNLOAD_GOLD_PLUGIN' in os.environ or ( # Required for LTO, which is used when is_official_build = true.
sys.platform.startswith('linux') and need_gold_plugin = sys.platform.startswith('linux')
'buildtype=Official' in os.environ.get('GYP_DEFINES', ''))
if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build: if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build:
print 'Clang is already up to date.' print 'Clang is already up to date.'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment