Commit 57340717 authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Stop coordinators before deallocating them

These coordinators were just being set to nil, without stopping. They
should be stopped first.

Change-Id: If1a1ffb632176c77b9d5d69655f0e9a4f2a3874c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544464Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#828209}
parent 12ad98e6
...@@ -1570,8 +1570,11 @@ NSString* const kBrowserViewControllerSnackbarCategory = ...@@ -1570,8 +1570,11 @@ NSString* const kBrowserViewControllerSnackbarCategory =
self.typingShield = nil; self.typingShield = nil;
if (_voiceSearchController) if (_voiceSearchController)
_voiceSearchController->SetDispatcher(nil); _voiceSearchController->SetDispatcher(nil);
[self.primaryToolbarCoordinator stop];
self.primaryToolbarCoordinator = nil; self.primaryToolbarCoordinator = nil;
[self.secondaryToolbarContainerCoordinator stop];
self.secondaryToolbarContainerCoordinator = nil; self.secondaryToolbarContainerCoordinator = nil;
[self.secondaryToolbarCoordinator stop];
self.secondaryToolbarCoordinator = nil; self.secondaryToolbarCoordinator = nil;
self.toolbarInterface = nil; self.toolbarInterface = nil;
[_toolbarUIUpdater stopUpdating]; [_toolbarUIUpdater stopUpdating];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment