Commit 5769c90b authored by sigbjornf@opera.com's avatar sigbjornf@opera.com

Oilpan: make r180096's FIXME comment accurate.

The underlying cause described in r180096 wasn't correct; update the
FIXME comment to make it more accurate.

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/461373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180147 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 4984e2e6
......@@ -55,12 +55,14 @@ static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic
// FIXME: HTML5 specification says this should be a HTMLCollection.
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
//
// FIXME: Oilpan: explicit conversion needed as there is currently
// no implicit RawPtr<T>(RawPtr<U>) constructor (for type
// convertible pairs T and U) that would implicitly convert a
// RawPtr<StaticElementList> to a RawPtr<NodeList> (the former is
// a subclass of the latter.) Such a conversion is needed to
// resolve the toV8() call.
// FIXME: Oilpan: explicitly convert adopt()'s result so as to
// disambiguate the (implicit) conversion of its
// PassRefPtrWillBeRawPtr<StaticElementList> result -- the
// other toV8() overload that introduces the ambiguity is
// toV8(NodeList*, ...).
//
// When adopt() no longer uses transition types, the conversion
// can be removed.
return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedItems)), info.Holder(), info.GetIsolate());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment