Migrate off BrowserThread::DeleteSoon in /content/browser/renderer_host/pepper

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=bbudge@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I92b2e2f80b080fa169592eb46db994b577463934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895637
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711750}

content/browser/renderer_host/pepper/pepper_proxy_lookup_helper.cc

@@ -78,8 +78,8 @@ PepperProxyLookupHelper::PepperProxyLookupHelper() {}
 PepperProxyLookupHelper::~PepperProxyLookupHelper() {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
 
-  BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE,
-                            std::move(ui_thread_helper_));
+  base::DeleteSoon(FROM_HERE, {BrowserThread::UI},
+                   std::move(ui_thread_helper_));
 }
 
 void PepperProxyLookupHelper::Start(

content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

@@ -126,8 +126,7 @@ PepperTCPSocketMessageFilter::~PepperTCPSocketMessageFilter() {
 #if defined(OS_CHROMEOS)
   // Close the firewall hole on UI thread if there is one.
   if (firewall_hole_) {
-    BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE,
-                              std::move(firewall_hole_));
+    base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, std::move(firewall_hole_));
   }
 #endif  // defined(OS_CHROMEOS)
   --g_num_tcp_filter_instances;