Commit 57a411f4 authored by wittman@chromium.org's avatar wittman@chromium.org

Close Views HTML authentication and tab modal confirm dialogs on interstitial WebUI

Configure Views HTML authentication and tab modal confirm dialogs to be
closed when interstitial WebUI is displayed (e.g. for SSL warnings prior
to page load).

This is effectively a no-op for these dialogs, but is desirable so that
all web contents modal dialogs have consistently configured behavior;
these dialogs are already closed at load start time which occurs before
interstitial WebUI is displayed.

BUG=240575
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23903025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222130 0039d316-1c4b-4281-b951-d872f2087c98
parent 8c4dd5e5
......@@ -163,6 +163,8 @@ class LoginHandlerViews : public LoginHandler,
requesting_contents->GetView()->GetNativeView(),
modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
web_contents_modal_dialog_manager->ShowDialog(dialog_->GetNativeView());
web_contents_modal_dialog_manager->SetCloseOnInterstitialWebUI(
dialog_->GetNativeView(), true);
NotifyAuthNeeded();
}
......
......@@ -63,6 +63,8 @@ TabModalConfirmDialogViews::TabModalConfirmDialogViews(
web_contents->GetView()->GetNativeView(),
modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
web_contents_modal_dialog_manager->ShowDialog(dialog_->GetNativeView());
web_contents_modal_dialog_manager->SetCloseOnInterstitialWebUI(
dialog_->GetNativeView(), true);
delegate_->set_close_delegate(this);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment