Commit 57b2b36e authored by Victor Hugo Vianna Silva's avatar Victor Hugo Vianna Silva Committed by Commit Bot

Update b4p TODOs

This CL updates TODOs pointing to closed b4p bugs to point to the newly
filed follow-up bugs.

Bug: None
Change-Id: I86ba9fb58a83f7cba33c6d001e4cd00008d7f3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282582Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#785330}
parent e9e09b60
......@@ -510,7 +510,7 @@
<message name="IDS_SETTINGS_PASSWORD_REMOVE_DIALOG_TITLE" desc="Title for the dialog that asks the user which versions of a password to remove (device, Google Account or both).">
Delete password?
</message>
<!-- TODO(crbug.com/1049141): Inject the website in the string and make it translateable. -->
<!-- TODO(crbug.com/1102294): Inject the website in the string and make it translateable. -->
<message translateable="false" name="IDS_SETTINGS_PASSWORD_REMOVE_DIALOG_BODY" desc="Description message for the dialog that asks the user which versions of a password to remove (device, Google Account or both).">
Your password is stored on this device and in your Google Account. Which one do you want to delete?
</message>
......
......@@ -69,7 +69,7 @@ class PasswordsPrivateDelegateImpl : public PasswordsPrivateDelegate,
api::passwords_private::ExportProgressStatus GetExportProgressStatus()
override;
bool IsOptedInForAccountStorage() override;
// TODO(crbug.com/1049141): Mimic the signature in PasswordFeatureManager.
// TODO(crbug.com/1102294): Mimic the signature in PasswordFeatureManager.
void SetAccountStorageOptIn(bool opt_in,
content::WebContents* web_contents) override;
std::vector<api::passwords_private::CompromisedCredential>
......
......@@ -37,7 +37,7 @@
</passwords-section>
</settings-subpage>
</template>
<!-- TODO(crbug.com/1049141): Add a learn-more-url, which will cause the
<!-- TODO(crbug.com/1102294): Add a learn-more-url, which will cause the
(?) button to appear. -->
<template is="dom-if" route-path="/passwords/device" no-search>
<settings-subpage
......
......@@ -42,7 +42,7 @@ export class MultiStoreExceptionEntry extends MultiStoreIdHandler {
* |contents_| and the id corresponding to its store is not set.
* @param {!PasswordManagerProxy.ExceptionEntry} otherEntry
*/
// TODO(crbug.com/1049141) Consider asserting frontendId as well.
// TODO(crbug.com/1102294) Consider asserting frontendId as well.
merge(otherEntry) {
assert(
(this.isPresentInAccount() && !otherEntry.fromAccountStore) ||
......
......@@ -42,7 +42,7 @@ export class MultiStorePasswordUiEntry extends MultiStoreIdHandler {
* |contents_| and the id corresponding to its store is not set.
* @param {!PasswordManagerProxy.PasswordUiEntry} otherEntry
*/
// TODO(crbug.com/1049141) Consider asserting frontendId as well.
// TODO(crbug.com/1102294) Consider asserting frontendId as well.
merge(otherEntry) {
assert(
(this.isPresentInAccount() && !otherEntry.fromAccountStore) ||
......
......@@ -11,7 +11,7 @@
<cr-dialog id="dialog" close-text="$i18n{close}">
<div slot="title">$i18n{passwordRemoveDialogTitle}</div>
<div slot="body">
<!-- TODO(crbug.com/1049141): Display the website and avatar. -->
<!-- TODO(crbug.com/1102294): Display the website and avatar. -->
<div>
$i18n{passwordRemoveDialogBody}
</div>
......
......@@ -301,7 +301,7 @@ Polymer({
* @param {!Event} event
* @private
*/
// TODO(crbug.com/1049141): Consider grouping the ctrl-z related code into
// TODO(crbug.com/1102294): Consider grouping the ctrl-z related code into
// a dedicated behavior.
onUndoKeyBinding_(event) {
const activeElement = getDeepActiveElement();
......
......@@ -290,7 +290,7 @@ void ManagePasswordsUIController::OnShowMoveToAccountBubble(
password_manager::metrics_util::MoveToAccountStoreTrigger::
kSuccessfulLoginWithProfileStorePassword);
passwords_data_.OnPasswordMovable(std::move(form_to_move));
// TODO(crbug.com/1060128): Add smartness like OnPasswordSubmitted?
// TODO(crbug.com/1100814): Add smartness like OnPasswordSubmitted?
bubble_status_ = BubbleStatus::SHOULD_POP_UP;
UpdateBubbleAndIconVisibility();
}
......
......@@ -83,7 +83,7 @@ MoveToAccountStoreBubbleView::MoveToAccountStoreBubbleView(
/*horizontal=*/0));
AddChildView(CreateDescription());
// TODO(crbug.com/1060128): Add images indicating "site"->"account" move.
// TODO(crbug.com/1100814): Add images indicating "site"->"account" move.
SetButtonLabel(ui::DIALOG_BUTTON_OK,
l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_MOVE_BUTTON));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment