Skip to content

GitLab

T
tangled
Commit 57d821e3 authored by Yuzu Saijo's avatar Yuzu Saijo Committed by Commit Bot
Browse files
Options

Reland "Reland introduce sharding to memory.leak_detection" 

This is a reland of 37bc2e24

*** SHERIFFS: if there is any failing memory leak tests, please file bug & disable them in https://cs.chromium.org/chromium/src/tools/perf/expectations.config?q=tools/perf/expectations.config instead of reverting this CL ***

Original change's description:
> Reland introduce sharding to memory.leak_detection
>
> This CL fixes a bug in test_suites.pyl and introduces sharding to memory.leak_detection benchmark.
> Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1180788
> TBR=nednguyen@chromium.org,dpranke@chromium.org
>
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: Ie1a3be0b3b47a9feb57d77a779a6df8cf8257a3c
> Reviewed-on: https://chromium-review.googlesource.com/1182714
> Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
> Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584644}

Change-Id: Ib54d75d47e39835a17d00834d468642d8b6bac2a
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi

TBR=yuzus@chromium.org, dpranke@chromium.org
NOTRY=true # reland

Change-Id: Ib54d75d47e39835a17d00834d468642d8b6bac2a
Reviewed-on: https://chromium-review.googlesource.com/1183241
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584711}
parent f02843e3
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 855 additions and 23 deletions
testing/buildbot/chromium.linux.json
View file @ 57d821e3
...@@ -821,8 +821,8 @@ ...@@ -821,8 +821,8 @@
"isolated_scripts": [ "isolated_scripts": [
{ {
"args": [ "args": [
"--benchmarks=memory.leak_detection",
"--smoke-test-mode", "--smoke-test-mode",
"--test-shard-map-filename=linux_leak_detection_shard_map.json",
"--upload-results", "--upload-results",
"--output-format=histograms", "--output-format=histograms",
"--browser=release", "--browser=release",
...@@ -844,7 +844,8 @@ ...@@ -844,7 +844,8 @@
"expiration": 36000, "expiration": 36000,
"hard_timeout": 10800, "hard_timeout": 10800,
"ignore_task_failure": false, "ignore_task_failure": false,
"io_timeout": 3600 "io_timeout": 3600,
"shards": 10
} }
} }
] ]
......
testing/buildbot/test_suites.pyl
View file @ 57d821e3
...@@ -1619,8 +1619,8 @@ ...@@ -1619,8 +1619,8 @@
'leak_detection_isolated_scripts': { 'leak_detection_isolated_scripts': {
'memory.leak_detection': { 'memory.leak_detection': {
'args': [ 'args': [
'--benchmarks=memory.leak_detection',
'--smoke-test-mode', '--smoke-test-mode',
'--test-shard-map-filename=linux_leak_detection_shard_map.json',
'--upload-results', '--upload-results',
'--output-format=histograms', '--output-format=histograms',
'--browser=release', '--browser=release',
...@@ -1641,6 +1641,7 @@ ...@@ -1641,6 +1641,7 @@
'hard_timeout': 10800, 'hard_timeout': 10800,
'ignore_task_failure': False, 'ignore_task_failure': False,
'io_timeout': 3600, 'io_timeout': 3600,
'shards': 10
}, },
}, },
}, },
......
tools/perf/contrib/leak_detection/data/leak_detection_004.wprgo.sha1 0 → 100644
View file @ 57d821e3
d33f6c522f28233b53c5a8de7499777d95a5b9e3
\ No newline at end of file
tools/perf/contrib/leak_detection/page_sets.py
View file @ 57d821e3
...@@ -57,8 +57,125 @@ class LeakDetectionStorySet(story_module.StorySet): ...@@ -57,8 +57,125 @@ class LeakDetectionStorySet(story_module.StorySet):
'https://www.baidu.com', 'https://www.baidu.com',
'https://www.wikipedia.org', 'https://www.wikipedia.org',
'http://www.qq.com', 'http://www.qq.com',
'https://world.taobao.com/',
'https://www.tmall.com/',
'http://www.amazon.com', 'http://www.amazon.com',
'http://www.twitter.com', 'http://www.twitter.com',
'https://www.instagram.com/',
'http://www.jd.com/',
'https://vk.com/',
'https://outlook.live.com',
'https://www.reddit.com/',
'https://weibo.com/',
'https://www.sina.com.cn/',
'https://www.360.cn/',
'https://yandex.ru/',
'https://www.blogger.com/',
'https://www.netflix.com/',
'https://www.pornhub.com/',
'https://www.linkedin.com/',
'https://www.yahoo.co.jp/',
'https://www.csdn.net/',
'https://www.alipay.com/',
'https://www.twitch.tv/',
'https://www.ebay.com/',
'https://www.microsoft.com/',
'https://www.xvideos.com/',
'https://mail.ru/',
'https://www.bing.com/',
'http://www.wikia.com/',
'https://www.office.com/',
'https://www.imdb.com/',
'https://www.aliexpress.com/',
'https://www.msn.com/',
'https://news.google.com/',
'https://www.theguardian.com/',
'https://www.indiatimes.com/',
'http://www.foxnews.com/',
'https://weather.com/',
'https://www.shutterstock.com/',
'https://docs.google.com/',
'https://wordpress.com/',
'https://www.apple.com/',
'https://play.google.com/store',
'https://www.dropbox.com/',
'https://soundcloud.com/',
'https://vimeo.com/',
'https://www.slideshare.net/',
'https://www.mediafire.com/',
'https://www.etsy.com/',
'https://www.ikea.com/',
'https://www.bestbuy.com/',
'https://www.homedepot.com/',
'https://www.target.com/',
'https://www.booking.com/',
'https://www.tripadvisor.com/',
'https://9gag.com/',
'https://www.expedia.com/',
'https://www.hotels.com/',
'https://www.roblox.com/',
'https://www.gamespot.com/',
'https://www.blizzard.com',
'https://ign.com/',
'https://www.yelp.com/',
'https://gizmodo.com/',
'https://www.gsmarena.com/',
'https://www.theverge.com/',
'https://www.nlm.nih.gov/',
'https://archive.org/',
'https://www.udemy.com/',
'https://answers.yahoo.com/',
'https://www.goodreads.com/',
'https://www.cricbuzz.com/',
'http://www.goal.com/',
'http://siteadvisor.com/',
'https://www.patreon.com/',
'https://www.jw.org/',
'http://europa.eu/',
'https://translate.google.com/',
'https://www.epicgames.com/',
'http://www.reverso.net/',
'https://play.na.leagueoflegends.com/',
'https://www.thesaurus.com/',
'https://www.weebly.com/',
'https://www.deviantart.com/',
'https://www.scribd.com/',
'https://www.livejournal.com/',
'https://www.hulu.com/',
'https://www.xfinity.com/',
# India Alexa top websites
'https://porn555.com/',
'https://www.onlinesbi.com/',
'https://www.flipkart.com/',
'https://www.hotstar.com/',
'https://www.incometaxindiaefiling.gov.in/',
'https://stackoverflow.com/',
'https://www.irctc.co.in/nget/',
'https://www.hdfcbank.com/',
'https://www.whatsapp.com/',
'https://uidai.gov.in/',
'https://billdesk.com/',
'https://www.icicibank.com/',
# US Alexa top websites
'https://imgur.com/',
'https://www.craigslist.org/',
'https://www.chase.com/',
'https://www.tumblr.com/',
'https://www.paypal.com/',
'http://www.espn.com/',
'https://edition.cnn.com/',
'https://www.pinterest.com/',
'https://www.nytimes.com/',
'https://github.com/',
'https://www.salesforce.com/',
# Japan Alexa top websites
'https://www.rakuten.co.jp/',
'http://www.nicovideo.jp/',
'https://fc2.com/',
'https://ameblo.jp/',
'http://kakaku.com/',
'https://www.goo.ne.jp/',
'https://www.pixiv.net/',
# websites which were found to be leaking in the past # websites which were found to be leaking in the past
'https://www.prezi.com', 'https://www.prezi.com',
'http://www.time.com', 'http://www.time.com',
...@@ -66,6 +183,71 @@ class LeakDetectionStorySet(story_module.StorySet): ...@@ -66,6 +183,71 @@ class LeakDetectionStorySet(story_module.StorySet):
'http://www.onlinedown.net', 'http://www.onlinedown.net',
'http://www.dailypost.ng', 'http://www.dailypost.ng',
'http://www.aljazeera.net', 'http://www.aljazeera.net',
'http://www.googleapps.com',
'http://www.airbnb.ch',
'http://www.livedoor.jp',
'http://www.blu-ray.com',
'http://www.block.io',
'http://www.hockeybuzz.com',
'http://www.benzworld.org',
'http://www.silverpop.com',
'http://www.ansa.it',
'http://www.gulfair.com',
'http://www.nusatrip.com',
'http://www.samsung-fun.ru',
'http://www.opentable.com',
'http://www.magnetmail.net',
'http://zzz.com.ua',
'http://a-rakumo.appspot.com',
'http://www.sakurafile.com',
'http://www.psiexams.com',
'http://www.contentful.com',
'http://www.estibot.com',
'http://www.mbs.de',
'http://www.zhengjie.com',
'http://www.sjp.pl',
'http://www.mastodon.social',
'http://www.horairetrain.net',
'http://www.torrentzeu.to',
'http://www.inbank.it',
'http://www.gradpoint.com',
'http://www.mail.bg',
'http://www.aaannunci.it',
'http://www.leandomainsearch.com',
'http://www.wpjam.com',
'http://www.nigma.ru',
'http://www.do-search.com',
'http://www.omniboxes.com',
'http://whu.edu.cn',
'http://support.wordpress.com',
'http://www.webwebweb.com',
'http://www.sick.com',
'http://www.iowacconline.com',
'http://hdu.edu.cn',
'http://www.register.com',
'http://www.careesma.in',
'http://www.bestdic.ir',
'http://www.privacyassistant.net',
'http://www.sklavenzentrale.com',
'http://www.podbay.fm',
'http://www.coco.fr',
'http://www.skipaas.com',
'http://www.chatword.org',
'http://www.ezcardinfo.com',
'http://www.daydao.com',
'http://www.expediapartnercentral.com',
'http://www.22find.com',
'http://www.e-shop.gr',
'http://www.indeed.com',
'http://www.highwaybus.com',
'http://www.pingpang.info',
'http://www.besgold.com',
'http://www.arabam.com',
'http://makfax.com.mk',
'http://game.co.za',
'http://www.savaari.com',
'http://www.520mojing.com',
'http://www.railsguides.jp',
] ]
resource_loading_urls_list = [ resource_loading_urls_list = [
'https://www.yahoo.com', 'https://www.yahoo.com',
...@@ -73,6 +255,8 @@ class LeakDetectionStorySet(story_module.StorySet): ...@@ -73,6 +255,8 @@ class LeakDetectionStorySet(story_module.StorySet):
'https://www.macys.com', 'https://www.macys.com',
'http://infomoney.com.br', 'http://infomoney.com.br',
'http://www.listindiario.com', 'http://www.listindiario.com',
'https://www.engadget.com/',
'https://www.sohu.com/',
] ]
for url in urls_list: for url in urls_list:
self.AddStory(LeakDetectionPage(url, self, url)) self.AddStory(LeakDetectionPage(url, self, url))
......
tools/perf/core/shard_maps/linux_leak_detection_shard_map.json 0 → 100644
View file @ 57d821e3
{
"0": {
"benchmarks": {
"memory.leak_detection" : {
"end": 20
}
}
},
"1": {
"benchmarks": {
"memory.leak_detection" : {
"begin":21,
"end": 40
}
}
},
"2": {
"benchmarks": {
"memory.leak_detection" : {
"begin":41,
"end": 60
}
}
},
"2": {
"benchmarks": {
"memory.leak_detection" : {
"begin":41,
"end": 60
}
}
},
"3": {
"benchmarks": {
"memory.leak_detection" : {
"begin":61,
"end": 80
}
}
},
"4": {
"benchmarks": {
"memory.leak_detection" : {
"begin":81,
"end": 100
}
}
},
"5": {
"benchmarks": {
"memory.leak_detection" : {
"begin":101,
"end": 120
}
}
},
"6": {
"benchmarks": {
"memory.leak_detection" : {
"begin":121,
"end": 140
}
}
},
"7": {
"benchmarks": {
"memory.leak_detection" : {
"begin":141,
"end": 160
}
}
},
"8": {
"benchmarks": {
"memory.leak_detection" : {
"begin":161,
"end": 180
}
}
},
"9": {
"benchmarks": {
"memory.leak_detection" : {
"begin":181,
"end": 200
}
}
},
"extra_infos": {
"num_stories": 200
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment