Commit 57f34d16 authored by Lukasz Anforowicz's avatar Lukasz Anforowicz Committed by Commit Bot

Re-enabling previously-flaky CrossSiteDocument*.BlockForVariousTargets

This CL re-enables CrossSiteDocumentBlockingTest.BlockForVariousTargets
because we speculate (as explained in https://crbug.com/1075663#c15)
that the root cause of the flakiness was unrelated to the test and has
been fixed by r792326 which fixed raciness in NestedMessagePumpAndroid
in July.

Fixed: 1075663
Change-Id: Ie370c65671d9d498056ffb95c4e75e8940e8d1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508910Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822689}
parent 40654a35
...@@ -770,14 +770,7 @@ IN_PROC_BROWSER_TEST_P(CrossSiteDocumentBlockingTest, BackToAboutBlank) { ...@@ -770,14 +770,7 @@ IN_PROC_BROWSER_TEST_P(CrossSiteDocumentBlockingTest, BackToAboutBlank) {
} }
} }
#if defined(OS_ANDROID) IN_PROC_BROWSER_TEST_P(CrossSiteDocumentBlockingTest, BlockForVariousTargets) {
// Test is flaky on Android, see crbug.com/1075663
#define MAYBE_BlockForVariousTargets DISABLED_BlockForVariousTargets
#else
#define MAYBE_BlockForVariousTargets BlockForVariousTargets
#endif
IN_PROC_BROWSER_TEST_P(CrossSiteDocumentBlockingTest,
MAYBE_BlockForVariousTargets) {
// This webpage loads a cross-site HTML page in different targets such as // This webpage loads a cross-site HTML page in different targets such as
// <img>,<link>,<embed>, etc. Since the requested document is blocked, and one // <img>,<link>,<embed>, etc. Since the requested document is blocked, and one
// character string (' ') is returned instead, this tests that the renderer // character string (' ') is returned instead, this tests that the renderer
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment