Commit 57fcf0ab authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

Mac: In the component build, make //chrome:chrome_framework a data_dep of :chrome_app.

The framework is bundled within the .app, but none of the dependent
shared libraries created by the component build are. Those need to be
expressed as runtime dependencies of the framework, and by extension the
app. But GN does not propagate that across the create_bundle rule so it
must be done manually.

Bug: 1010347
Change-Id: If4b08329c97e7ef5b0e5073fbb26252b922c50a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846075
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704057}
parent ca0e7251
......@@ -598,6 +598,18 @@ if (is_win) {
ldflags = [ "-Wl,-exported_symbols_list," +
rebase_path("app/app.exports", root_build_dir) ]
}
if (is_component_build) {
# The Framework is packaged inside the .app bundle. But when using the
# component build, all the dependent shared libraries of :chrome_dll are
# not packaged within the framework. This data_deps line makes all of
# those dependent libraries runtime dependencies of the .app bundle.
# This is a bit of a hack, since GN deliberately terminates its search
# for runtime_deps at create_bundle nodes (https://crbug.com/1010347).
data_deps = [
":chrome_framework",
]
}
}
compiled_action("chrome_app_strings") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment