Commit 580f1186 authored by Tommy Steimel's avatar Tommy Steimel Committed by Commit Bot

Fix gn check issues for chrome/browser/share

This CL adds the necessary deps to chrome/browser/share to pass `gn
check`. chrome/browser/share depends on the ProfileManager in
chrome/browser, so we allow circular dependencies.

Bug: 1105857
Change-Id: Ic2aec390319e7e16d7d47d06bb1299555b3d6194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300220Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788712}
parent 1b907767
......@@ -68,7 +68,6 @@ no_check_targets = [
"//chrome/browser/safe_browsing/android:*", # 3 errors
"//chrome/browser/safe_browsing:*", # 85 errors
"//chrome/browser/safety_check/android:*", # 3 errors
"//chrome/browser/share:*", # 7 errors
"//chrome/browser/storage_access_api:*", # 2 errors
"//chrome/browser/touch_to_fill/android:*", # 8 errors
"//chrome/browser/touch_to_fill:*", # 5 errors
......
......@@ -2951,6 +2951,7 @@ static_library("browser") {
"//third_party/smhasher:murmurhash2",
"//url:origin_android",
]
allow_circular_includes_from += [ "//chrome/browser/share" ]
deps += [ "//chrome/browser/engagement/android:jni_headers" ]
deps -= [ "//components/storage_monitor" ]
......
......@@ -19,7 +19,9 @@ source_set("share") {
"//chrome/browser/share/android:jni_headers",
"//chrome/services/qrcode_generator/public/cpp",
"//chrome/services/qrcode_generator/public/mojom",
"//content/public/browser",
"//skia",
"//ui/gfx",
]
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment