Commit 581180f8 authored by Swapnil's avatar Swapnil Committed by Chromium LUCI CQ

[Extensions] Use policy-enforced update URL in app uninstall dialog

This change gives ExtensionManagement control over update URL used when
updating extensions. Previously only first install was affected, all
later updates used update URL from the extension manifest. Now update
URL from the policy can be used if extension management said so.
This change is split into multiple CLs.

Update URL from policy is handled in
https://chromium-review.googlesource.com/c/chromium/src/+/2593260.

Bug: b:168097163
Change-Id: I73c4bc11c1a18bcbadf73bcc611a28cf880517bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593266
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840998}
parent 76f6dce3
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "build/chromeos_buildflags.h" #include "build/chromeos_buildflags.h"
#include "chrome/browser/extensions/extension_management.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_dialogs.h" #include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/browser_navigator.h" #include "chrome/browser/ui/browser_navigator.h"
...@@ -276,7 +277,9 @@ void AppUninstallDialogView::InitializeViewForExtension( ...@@ -276,7 +277,9 @@ void AppUninstallDialogView::InitializeViewForExtension(
app_id); app_id);
DCHECK(extension); DCHECK(extension);
if (extensions::ManifestURL::UpdatesFromGallery(extension)) { extensions::ExtensionManagement* extension_management =
extensions::ExtensionManagementFactory::GetForBrowserContext(profile);
if (extension_management->UpdatesFromWebstore(*extension)) {
auto report_abuse_checkbox = std::make_unique<views::Checkbox>( auto report_abuse_checkbox = std::make_unique<views::Checkbox>(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_UNINSTALL_REPORT_ABUSE)); l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_UNINSTALL_REPORT_ABUSE));
report_abuse_checkbox->SetMultiLine(true); report_abuse_checkbox->SetMultiLine(true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment