Add implementation for PrimaryAccountMutatorImpl [1/N]

Add implementation and test for PrimaryAccountMutatorImpl
methods {Set,Is}SettingPrimaryAccountAllowed.

Bug: 889902, 806778
Change-Id: Ibd75f2b3a988b4c403eab3b682a157e31e4b2e18
Reviewed-on: https://chromium-review.googlesource.com/c/1335937Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608390}

components/signin/core/browser/signin_manager.cc

@@ -324,6 +324,10 @@ bool SigninManager::IsSigninAllowed() const {
   return signin_allowed_.GetValue();
 }
 
+void SigninManager::SetSigninAllowed(bool allowed) {
+  signin_allowed_.SetValue(allowed);
+}
+
 void SigninManager::OnSigninAllowedPrefChanged() {
   if (!IsSigninAllowed() && (IsAuthenticated() || AuthInProgress()))
     SignOut(signin_metrics::SIGNOUT_PREF_CHANGED,

components/signin/core/browser/signin_manager.h

@@ -163,8 +163,13 @@ class SigninManager : public SigninManagerBase,
   // Returns true if there's a signin in progress.
   bool AuthInProgress() const override;
 
+  // Returns whether sign-in is allowed.
+  // TODO(crbug.com/806778): Remove method in super-class.
   bool IsSigninAllowed() const override;
 
+  // Sets whether sign-in is allowed or not.
+  void SetSigninAllowed(bool allowed);
+
   // Returns true if the passed username is allowed by policy. Virtual for
   // mocking in tests.
   virtual bool IsAllowedUsername(const std::string& username) const;

components/signin/core/browser/signin_manager_base.h

@@ -129,11 +129,9 @@ class SigninManagerBase : public KeyedService {
   bool IsInitialized() const;
 
   // Returns true if a signin to Chrome is allowed (by policy or pref).
-  // TODO(tim): kSigninAllowed is defined for all platforms in pref_names.h.
-  // If kSigninAllowed pref was non-Chrome OS-only, this method wouldn't be
-  // needed, but as is we provide this method to let all interested code
-  // code query the value in one way, versus half using PrefService directly
-  // and the other half using SigninManager.
+  // TODO(crbug.com/806778): this method should not be used externally,
+  // instead the value of the kSigninAllowed preference should be checked.
+  // Once all external code has been modified, this method will be removed.
   virtual bool IsSigninAllowed() const;
 
   // If a user has previously signed in (and has not signed out), this returns

services/identity/BUILD.gn

@@ -46,6 +46,7 @@ source_set("tests") {
     "//mojo/public/cpp/bindings:bindings",
     "//services/identity/public/cpp",
     "//services/identity/public/cpp:test_support",
+    "//services/identity/public/cpp:tests",
     "//services/identity/public/mojom",
     "//services/service_manager/public/cpp",
     "//services/service_manager/public/cpp:service_test_support",

services/identity/public/cpp/BUILD.gn

@@ -64,3 +64,18 @@ source_set("test_support") {
     "//components/sync_preferences:test_support",
   ]
 }
+
+source_set("tests") {
+  testonly = true
+  sources = [
+    "primary_account_mutator_unittest.cc",
+  ]
+
+  deps = [
+    ":cpp",
+    ":test_support",
+    "//base",
+    "//base/test:test_support",
+    "//testing/gtest",
+  ]
+}

services/identity/public/cpp/primary_account_mutator_impl.cc

@@ -33,12 +33,11 @@ void PrimaryAccountMutatorImpl::ClearPrimaryAccount(
 }
 
 bool PrimaryAccountMutatorImpl::IsSettingPrimaryAccountAllowed() const {
-  NOTIMPLEMENTED();
-  return false;
+  return signin_manager_->IsSigninAllowed();
 }
 
 void PrimaryAccountMutatorImpl::SetSettingPrimaryAccountAllowed(bool allowed) {
-  NOTIMPLEMENTED();
+  signin_manager_->SetSigninAllowed(allowed);
 }
 
 bool PrimaryAccountMutatorImpl::IsClearingPrimaryAccountAllowed() const {

services/identity/public/cpp/primary_account_mutator_unittest.cc

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "services/identity/public/cpp/primary_account_mutator.h"
+
+#include "base/test/scoped_task_environment.h"
+#include "services/identity/public/cpp/identity_test_environment.h"
+#include "testing/platform_test.h"
+
+using PrimaryAccountMutatorTest = PlatformTest;
+
+// Checks that the method to control whether setting the primary account is
+// working correctly and that the setting is respected by SetPrimaryAccount().
+TEST_F(PrimaryAccountMutatorTest, SetSettingPrimaryAccountAllowed) {
+  base::test::ScopedTaskEnvironment task_environment;
+  identity::IdentityTestEnvironment environment;
+
+  identity::IdentityManager* identity_manager = environment.identity_manager();
+  identity::PrimaryAccountMutator* primary_account_mutator =
+      identity_manager->GetPrimaryAccountMutator();
+
+  // Abort the test if the current platform does not support mutation of the
+  // primary account (the returned PrimaryAccountMutator* will be null).
+  if (!primary_account_mutator)
+    return;
+
+  primary_account_mutator->SetSettingPrimaryAccountAllowed(false);
+  EXPECT_FALSE(primary_account_mutator->IsSettingPrimaryAccountAllowed());
+
+  primary_account_mutator->SetSettingPrimaryAccountAllowed(true);
+  EXPECT_TRUE(primary_account_mutator->IsSettingPrimaryAccountAllowed());
+}