Commit 58646791 authored by Siyu An's avatar Siyu An Committed by Commit Bot

[Autofill Offer] Temporarily remove offer_details_url validation

We don't need this field in the MVP scope, and we are not 100% sure
what format of the text will be. So remove it for now. Will add it back
when we really use this.

Bug: 1112095
Change-Id: I919c5520cf14da24d9474fff0b3f95716fd31935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432322Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811434}
parent d3dc0fa3
...@@ -499,12 +499,6 @@ bool IsOfferSpecificsValid(const sync_pb::AutofillOfferSpecifics specifics) { ...@@ -499,12 +499,6 @@ bool IsOfferSpecificsValid(const sync_pb::AutofillOfferSpecifics specifics) {
if (!specifics.has_id()) if (!specifics.has_id())
return false; return false;
// A valid offer has a non-empty offer details url and the url must be valid.
if (!specifics.has_offer_details_url() ||
!GURL(specifics.offer_details_url()).is_valid()) {
return false;
}
// A valid offer has at least one merchant domain. // A valid offer has at least one merchant domain.
if (specifics.merchant_domain().size() == 0) { if (specifics.merchant_domain().size() == 0) {
return false; return false;
......
...@@ -316,15 +316,6 @@ TEST_F(AutofillSyncBridgeUtilTest, IsOfferSpecificsValid) { ...@@ -316,15 +316,6 @@ TEST_F(AutofillSyncBridgeUtilTest, IsOfferSpecificsValid) {
// Expects specifics without id to be invalid. // Expects specifics without id to be invalid.
EXPECT_FALSE(IsOfferSpecificsValid(specifics)); EXPECT_FALSE(IsOfferSpecificsValid(specifics));
SetAutofillOfferSpecificsFromOfferData(test::GetCardLinkedOfferData1(),
&specifics);
specifics.set_offer_details_url("invalid url");
// Expects specifics with invalid offer_details_url to be invalid.
EXPECT_FALSE(IsOfferSpecificsValid(specifics));
specifics.clear_offer_details_url();
// Expects specifics without offer_details_url to be invalid.
EXPECT_FALSE(IsOfferSpecificsValid(specifics));
SetAutofillOfferSpecificsFromOfferData(test::GetCardLinkedOfferData1(), SetAutofillOfferSpecificsFromOfferData(test::GetCardLinkedOfferData1(),
&specifics); &specifics);
specifics.clear_merchant_domain(); specifics.clear_merchant_domain();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment