Commit 5870ac37 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Update adding_to_third_party to prevent confusion

* Rather than guiding devs to getting the code and preparing a CL, ask
them to first obtain Chrome Eng Review. This will make sure devs
consider the checkout size and build times up front
* Add a section about adding new Node packages. This was previously
undocumented and not clear for new contributors.

Bug: 1012733
Change-Id: I07317d40adb1130b8a1acb6de8b7bd547a09e876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867149Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707330}
parent 528e9a3e
......@@ -18,6 +18,15 @@ situations and need explicit approval; don't assume that because there's some
other directory with third_party in the name it's okay to put new things
there.
## Before you start
To make sure the inclusion of a new third_party project makes sense for the
Chromium project, you should first obtain Chrome Eng Review approval.
Googlers should see go/chrome-eng-review and review existing topics in
g/chrome-eng-review. Please include information about the additional checkout
size, build times, and binary sizes. Please also make sure that the motivation
for your project is clear, e.g., a design doc has been circulated.
## Get the code
There are two common ways to depend on third-party code: you can reference a
......@@ -27,6 +36,14 @@ access to the history; the latter is better if you don't need the full history
of the repo or don't need to pick up every single change. And, of course, if
the code you need isn't in a Git repo, you have to do the latter.
### Node packages
To include a Node package, add the dependency to the
[Node package.json](../third_party/node/package.json). Make sure to update
the corresponding [`npm_exclude.txt`](../third_party/node/npm_exclude.txt)
and [`npm_include.txt`](../third_party/node/npm_include.txt) to make the code
available during checkout.
### Pulling the code via DEPS
If the code is in a Git repo that you want to mirror, please file an [infra git
......@@ -126,10 +143,6 @@ following sign-offs. Some of these are accessible to Googlers only.
Non-Googlers can email one of the people in
[//third_party/OWNERS](../third_party/OWNERS) for help.
* Get Chrome Eng Review approval. Googlers should see
go/chrome-eng-review. Please include information about the additional
checkout size, build times, and binary sizes. Please also make sure that the
motivation for your project is clear, e.g., a design doc has been circulated.
* Get security@chromium.org approval. Email the list with relevant details and
a link to the CL. Third party code is a hot spot for security vulnerabilities.
When adding a new package that could potentially carry security risk, make
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment