Commit 5879a9d2 authored by David Roger's avatar David Roger Committed by Commit Bot

[signin] Fix regression in MergeSigninCredentialIntoCookieJar

The CL https://chromium-review.googlesource.com/c/chromium/src/+/1104682/9/components/signin/core/browser/signin_manager.cc
introduced a regression, leading to cookies not being merged correctly.
The cookies should be merged in all cases except Mirror, but that CL
did the opposite (only merging cookies when Mirror is enabled)

Change-Id: Ib3c5454259ff6b7ec82bb2411bcff011bc63f3e1
Bug: 777774
Reviewed-on: https://chromium-review.googlesource.com/1109976Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569287}
parent d8fc05b9
...@@ -393,8 +393,7 @@ void SigninManager::DisableOneClickSignIn(PrefService* prefs) { ...@@ -393,8 +393,7 @@ void SigninManager::DisableOneClickSignIn(PrefService* prefs) {
} }
void SigninManager::MergeSigninCredentialIntoCookieJar() { void SigninManager::MergeSigninCredentialIntoCookieJar() {
#if !defined(OS_IOS) if (account_consistency_ == signin::AccountConsistencyMethod::kMirror)
if (account_consistency_ != signin::AccountConsistencyMethod::kMirror)
return; return;
if (!IsAuthenticated()) if (!IsAuthenticated())
...@@ -402,7 +401,6 @@ void SigninManager::MergeSigninCredentialIntoCookieJar() { ...@@ -402,7 +401,6 @@ void SigninManager::MergeSigninCredentialIntoCookieJar() {
cookie_manager_service_->AddAccountToCookie(GetAuthenticatedAccountId(), cookie_manager_service_->AddAccountToCookie(GetAuthenticatedAccountId(),
"ChromiumSigninManager"); "ChromiumSigninManager");
#endif // !defined(OS_IOS)
} }
void SigninManager::CompletePendingSignin() { void SigninManager::CompletePendingSignin() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment