Revert "Extract unified consent constants target."

This reverts commit cf629e19.

Reason for revert: Causing a compile issue: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898221248587802272/+/steps/compile/0/stdout

This removes kAdvancedSigninSettingsLinkIdentifier which is used by external_url_signing_egtest.mm

Original change's description:
> Extract unified consent constants target.
> 
> Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations.
> 
> Bug: 922813, 1015907
> Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710479}

TBR=rohitrao@chromium.org,jlebel@chromium.org,zhaoyangli@chromium.org

Change-Id: I1035a519391d68b553770ba3c12747cfe23e6050
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922813, 1015907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888721Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710520}

ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm

@@ -22,7 +22,6 @@
 #include "ios/chrome/browser/signin/identity_manager_factory.h"
 #include "ios/chrome/browser/sync/consent_auditor_factory.h"
 #include "ios/chrome/browser/sync/ios_user_event_service_factory.h"
-#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h"
 #import "ios/chrome/browser/ui/util/transparent_link_button.h"
 #include "ios/chrome/browser/unified_consent/unified_consent_service_factory.h"

ios/chrome/browser/ui/authentication/signin_earl_grey_ui.mm

@@ -11,7 +11,6 @@
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.h"
-#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h"
 #import "ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest_util.h"
 #import "ios/chrome/browser/ui/util/transparent_link_button.h"

ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn

@@ -48,16 +48,4 @@ source_set("unified_consent_ui") {
     "//ios/third_party/material_components_ios",
     "//ui/base",
   ]
-  public_deps = [
-    ":constants",
-  ]
-}
-
-source_set("constants") {
-  configs += [ "//build/config/compiler:enable_arc" ]
-  sources = [
-    "unified_consent_constants.h",
-    "unified_consent_constants.mm",
-  ]
-  libs = [ "Foundation.framework" ]
 }

ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.h

-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_CONSTANTS_H_
-#define IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_CONSTANTS_H_
-
-#import <Foundation/Foundation.h>
-
-// Accessibility identifier to open the advanced sign-in settings view.
-extern NSString* const kAdvancedSigninSettingsLinkIdentifier;
-// Accessibility identifier for |-UnifiedConsentViewController.view|.
-extern NSString* const kUnifiedConsentScrollViewIdentifier;
-
-#endif  // IOS_CHROME_BROWSER_UI_AUTHENTICATION_UNIFIED_CONSENT_UNIFIED_CONSENT_CONSTANTS_H_

ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.mm

-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.h"
-
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
-NSString* const kAdvancedSigninSettingsLinkIdentifier =
-    @"AdvancedSigninSettingsLinkIdentifier";
-NSString* const kUnifiedConsentScrollViewIdentifier =
-    @"kUnifiedConsentScrollViewIdentifier";

ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h

@@ -9,6 +9,11 @@
 
 #include <vector>
 
+// Accessibility identifier to open the advanced sign-in settings view.
+extern NSString* const kAdvancedSigninSettingsLinkIdentifier;
+// Accessibility identifier for |-UnifiedConsentViewController.view|.
+extern NSString* const kUnifiedConsentScrollViewIdentifier;
+
 @protocol UnifiedConsentViewControllerDelegate;
 
 // UnifiedConsentViewController is a sub view controller to ask for the user

ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm

@@ -9,7 +9,6 @@
 #include "ios/chrome/browser/application_context.h"
 #import "ios/chrome/browser/ui/authentication/authentication_constants.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.h"
-#import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_constants.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller_delegate.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/util/label_link_controller.h"
@@ -27,6 +26,11 @@
 #error "This file requires ARC support."
 #endif
 
+NSString* const kAdvancedSigninSettingsLinkIdentifier =
+    @"AdvancedSigninSettingsLinkIdentifier";
+NSString* const kUnifiedConsentScrollViewIdentifier =
+    @"kUnifiedConsentScrollViewIdentifier";
+
 namespace {
 
 // Vertical margin the main title and the identity picker.