Apply base_bind_rewriters to //net/proxy_resolution

*** Note: There is no behavior change from this patch. ***

This CL replaces calls to base::{Bind,BindRepeating} with calls to
base::BindOnce, and removes calls to base::AdaptCallbackForRepeating
when the returned base::RepeatingCallback is immediately converted
to a base::OnceCallback.

This CL was uploaded by git cl split.

R=mmenke@chromium.org

Bug: 714018
Change-Id: Id81c3450f3dc9c2d4e0b9cf062b5ee43e1c71e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778770Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com>
Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com>
Cr-Commit-Position: refs/heads/master@{#692309}

net/proxy_resolution/multi_threaded_proxy_resolver_unittest.cc

@@ -737,7 +737,7 @@ TEST_F(MultiThreadedProxyResolverTest, CancelCreate) {
     std::unique_ptr<ProxyResolver> resolver;
     EXPECT_EQ(ERR_IO_PENDING, resolver_factory.CreateProxyResolver(
                                   PacFileData::FromUTF8("pac script bytes"),
-                                  &resolver, base::Bind(&Fail), &request));
+                                  &resolver, base::BindOnce(&Fail), &request));
     EXPECT_TRUE(request);
     request.reset();
   }
@@ -782,7 +782,7 @@ TEST_F(MultiThreadedProxyResolverTest, DestroyFactoryWithRequestsInProgress) {
         kNumThreads, std::make_unique<BlockableProxyResolverFactory>());
     EXPECT_EQ(ERR_IO_PENDING, resolver_factory.CreateProxyResolver(
                                   PacFileData::FromUTF8("pac script bytes"),
-                                  &resolver, base::Bind(&Fail), &request));
+                                  &resolver, base::BindOnce(&Fail), &request));
     EXPECT_TRUE(request);
   }
   // The factory destructor will block until the worker thread stops, but it may

net/proxy_resolution/pac_file_decider.cc

@@ -286,7 +286,7 @@ int PacFileDecider::DoQuickCheck() {
   next_state_ = STATE_QUICK_CHECK_COMPLETE;
   quick_check_timer_.Start(
       FROM_HERE, base::TimeDelta::FromMilliseconds(kQuickCheckDelayMs),
-      base::BindRepeating(callback, ERR_NAME_NOT_RESOLVED));
+      base::BindOnce(callback, ERR_NAME_NOT_RESOLVED));
 
   return resolve_request_->Start(callback);
 }
@@ -323,7 +323,7 @@ int PacFileDecider::DoFetchPacScript() {
 
     return dhcp_pac_file_fetcher_->Fetch(
         &pac_script_,
-        base::Bind(&PacFileDecider::OnIOCompletion, base::Unretained(this)),
+        base::BindOnce(&PacFileDecider::OnIOCompletion, base::Unretained(this)),
         net_log_, NetworkTrafficAnnotationTag(traffic_annotation_));
   }
 
@@ -334,7 +334,7 @@ int PacFileDecider::DoFetchPacScript() {
 
   return pac_file_fetcher_->Fetch(
       effective_pac_url, &pac_script_,
-      base::Bind(&PacFileDecider::OnIOCompletion, base::Unretained(this)),
+      base::BindOnce(&PacFileDecider::OnIOCompletion, base::Unretained(this)),
       NetworkTrafficAnnotationTag(traffic_annotation_));
 }
 

net/proxy_resolution/proxy_resolution_service.cc

@@ -571,9 +571,10 @@ class ProxyResolutionService::InitProxyResolver {
   int DoDecidePacFile() {
     next_state_ = STATE_DECIDE_PAC_FILE_COMPLETE;
 
-    return decider_->Start(
-        config_, wait_delay_, proxy_resolver_factory_->expects_pac_bytes(),
-        base::Bind(&InitProxyResolver::OnIOCompletion, base::Unretained(this)));
+    return decider_->Start(config_, wait_delay_,
+                           proxy_resolver_factory_->expects_pac_bytes(),
+                           base::BindOnce(&InitProxyResolver::OnIOCompletion,
+                                          base::Unretained(this)));
   }
 
   int DoDecidePacFileComplete(int result) {
@@ -593,7 +594,8 @@ class ProxyResolutionService::InitProxyResolver {
     next_state_ = STATE_CREATE_RESOLVER_COMPLETE;
     return proxy_resolver_factory_->CreateProxyResolver(
         script_data_.data, proxy_resolver_,
-        base::Bind(&InitProxyResolver::OnIOCompletion, base::Unretained(this)),
+        base::BindOnce(&InitProxyResolver::OnIOCompletion,
+                       base::Unretained(this)),
         &create_resolver_request_);
   }
 
@@ -740,8 +742,8 @@ class ProxyResolutionService::PacFileDeciderPoller {
     decider_->set_quick_check_enabled(quick_check_enabled_);
     int result = decider_->Start(
         config_, TimeDelta(), proxy_resolver_expects_pac_bytes_,
-        base::Bind(&PacFileDeciderPoller::OnPacFileDeciderCompleted,
-                   base::Unretained(this)));
+        base::BindOnce(&PacFileDeciderPoller::OnPacFileDeciderCompleted,
+                       base::Unretained(this)));
 
     if (result != ERR_IO_PENDING)
       OnPacFileDeciderCompleted(result);
@@ -945,8 +947,8 @@ int ProxyResolutionService::RequestImpl::Start() {
 
   return resolver()->GetProxyForURL(
       url_, results_,
-      base::Bind(&ProxyResolutionService::RequestImpl::QueryComplete,
-                 base::Unretained(this)),
+      base::BindOnce(&ProxyResolutionService::RequestImpl::QueryComplete,
+                     base::Unretained(this)),
       &resolve_job_, net_log_);
 }
 
@@ -1664,8 +1666,8 @@ void ProxyResolutionService::InitializeUsingLastFetchedConfig() {
       &resolver_, resolver_factory_.get(), pac_file_fetcher_.get(),
       dhcp_pac_file_fetcher_.get(), net_log_, fetched_config_.value(),
       wait_delay,
-      base::Bind(&ProxyResolutionService::OnInitProxyResolverComplete,
-                 base::Unretained(this)));
+      base::BindOnce(&ProxyResolutionService::OnInitProxyResolverComplete,
+                     base::Unretained(this)));
 
   if (rv != ERR_IO_PENDING)
     OnInitProxyResolverComplete(rv);
@@ -1686,8 +1688,8 @@ void ProxyResolutionService::InitializeUsingDecidedConfig(
   int rv = init_proxy_resolver_->StartSkipDecider(
       &resolver_, resolver_factory_.get(), effective_config, decider_result,
       script_data,
-      base::Bind(&ProxyResolutionService::OnInitProxyResolverComplete,
-                 base::Unretained(this)));
+      base::BindOnce(&ProxyResolutionService::OnInitProxyResolverComplete,
+                     base::Unretained(this)));
 
   if (rv != ERR_IO_PENDING)
     OnInitProxyResolverComplete(rv);