Commit 58a6e4a8 authored by Pauline Leitao's avatar Pauline Leitao Committed by Commit Bot

[Sync] Fix missing titles in chrome:://sync-internals

Node titles are not being shown in Sync Node Browser due to an issue
with EntityData field renaming, under the CL in [1]. This CL fixes this
issue.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1648168

Bug: 984956
Change-Id: I9b54517cf6d6b1070e98777581db3ab7f7f8100d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706520
Commit-Queue: Pauline Leitao <psivieroleitao@google.com>
Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681833}
parent 4146c7bb
...@@ -84,6 +84,9 @@ std::unique_ptr<base::DictionaryValue> EntityData::ToDictionaryValue() { ...@@ -84,6 +84,9 @@ std::unique_ptr<base::DictionaryValue> EntityData::ToDictionaryValue() {
ADD_TO_DICT(dict, originator_cache_guid); ADD_TO_DICT(dict, originator_cache_guid);
ADD_TO_DICT(dict, originator_client_item_id); ADD_TO_DICT(dict, originator_client_item_id);
ADD_TO_DICT(dict, server_defined_unique_tag); ADD_TO_DICT(dict, server_defined_unique_tag);
// The string "NON_UNIQUE_NAME" is used in sync-internals to identify the node
// title.
dict->SetString("NON_UNIQUE_NAME", name);
ADD_TO_DICT(dict, name); ADD_TO_DICT(dict, name);
ADD_TO_DICT(dict, parent_id); ADD_TO_DICT(dict, parent_id);
ADD_TO_DICT_WITH_TRANSFORM(dict, ctime, GetTimeDebugString); ADD_TO_DICT_WITH_TRANSFORM(dict, ctime, GetTimeDebugString);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment