Commit 58ba47e1 authored by mgiuca@chromium.org's avatar mgiuca@chromium.org

Minor cleanup of app_window_browsertest.

Use EXPECT_GT instead of EXPECT_TRUE. Made URLs clickable.

Review URL: https://codereview.chromium.org/216573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260481 0039d316-1c4b-4281-b951-d872f2087c98
parent e3a8ebb9
...@@ -23,7 +23,7 @@ typedef extensions::PlatformAppBrowserTest AppWindowBrowserTest; ...@@ -23,7 +23,7 @@ typedef extensions::PlatformAppBrowserTest AppWindowBrowserTest;
#endif #endif
// Verifies that the NativeAppWindows implement GetFrameInsets() correctly. // Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
// See crbug.com/346115 // See http://crbug.com/346115
IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) { IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
AppWindow* app_window = CreateTestAppWindow("{}"); AppWindow* app_window = CreateTestAppWindow("{}");
NativeAppWindow* native_window = app_window->GetBaseWindow(); NativeAppWindow* native_window = app_window->GetBaseWindow();
...@@ -31,7 +31,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) { ...@@ -31,7 +31,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
// It is a reasonable assumption that the top padding must be greater than // It is a reasonable assumption that the top padding must be greater than
// the bottom padding due to the title bar. // the bottom padding due to the title bar.
EXPECT_TRUE(insets.top() > insets.bottom()); EXPECT_GT(insets.top(), insets.bottom());
CloseAppWindow(app_window); CloseAppWindow(app_window);
} }
...@@ -46,7 +46,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) { ...@@ -46,7 +46,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
#endif #endif
// Verifies that the NativeAppWindows implement GetFrameInsets() correctly. // Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
// See crbug.com/346115 // See http://crbug.com/346115
IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) { IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) {
AppWindow* app_window = AppWindow* app_window =
CreateTestAppWindow("{ \"frame\": { \"color\": \"#ffffff\" } }"); CreateTestAppWindow("{ \"frame\": { \"color\": \"#ffffff\" } }");
...@@ -55,7 +55,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) { ...@@ -55,7 +55,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) {
// It is a reasonable assumption that the top padding must be greater than // It is a reasonable assumption that the top padding must be greater than
// the bottom padding due to the title bar. // the bottom padding due to the title bar.
EXPECT_TRUE(insets.top() > insets.bottom()); EXPECT_GT(insets.top(), insets.bottom());
CloseAppWindow(app_window); CloseAppWindow(app_window);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment