Commit 58c115e7 authored by Manuel Rego Casasnovas's avatar Manuel Rego Casasnovas Committed by Commit Bot

[css-contain] Fix height of select multiple with size containment

Multiple select elements with "contain: size" should have
the same height than an empty element with no children.
To fix this this patch adds a new condition in
LayoutListBox::ItemHeight() so it uses the DefaultItemHeight()
if the element has size containment.

BUG=980380
TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-003.html
TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-004.html
TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-005.html

Change-Id: I37c3de82ee591272f97a0b3db5761d914d17efbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695409
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676096}
parent 98ad5095
...@@ -83,7 +83,7 @@ LayoutUnit LayoutListBox::ItemHeight() const { ...@@ -83,7 +83,7 @@ LayoutUnit LayoutListBox::ItemHeight() const {
return LayoutUnit(); return LayoutUnit();
const auto& items = select->GetListItems(); const auto& items = select->GetListItems();
if (items.IsEmpty()) if (items.IsEmpty() || ShouldApplySizeContainment())
return DefaultItemHeight(); return DefaultItemHeight();
LayoutUnit max_height; LayoutUnit max_height;
......
...@@ -3217,12 +3217,6 @@ crbug.com/968164 external/wpt/css/css-ui/webkit-appearance-menulist-button-001.h ...@@ -3217,12 +3217,6 @@ crbug.com/968164 external/wpt/css/css-ui/webkit-appearance-menulist-button-001.h
# ====== New tests from wpt-importer added here ====== # ====== New tests from wpt-importer added here ======
crbug.com/626703 external/wpt/webauthn/idlharness-manual.https.window.js [ Skip ] crbug.com/626703 external/wpt/webauthn/idlharness-manual.https.window.js [ Skip ]
crbug.com/626703 [ Mac ] external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-003.html [ Failure ]
crbug.com/626703 [ Mac ] virtual/layout_ng_experimental/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-004.html [ Failure ]
crbug.com/626703 virtual/layout_ng_experimental/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-005.html [ Failure ]
crbug.com/626703 [ Mac ] virtual/layout_ng_experimental/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-003.html [ Failure ]
crbug.com/626703 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-005.html [ Failure ]
crbug.com/626703 [ Mac ] external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-004.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-fraktur-001.tentative.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-fraktur-001.tentative.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-stretched-001.tentative.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-stretched-001.tentative.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-looped-001.tentative.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/text-transform/math/text-transform-math-looped-001.tentative.html [ Failure ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment