Change ButtonPressed overrides to callbacks: ash/in_session_auth/

Bug: 772945
Change-Id: Idc5e97a2f8161f6e673a75352c4a398b990a7a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515940
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823606}

ash/in_session_auth/auth_dialog_contents_view.cc

@@ -381,25 +381,6 @@ void AuthDialogContentsView::AddActionButtonsView() {
   // TODO(b/156258540): Add a "Need help?" button that links to a HC article.
 }
 
-void AuthDialogContentsView::ButtonPressed(views::Button* sender,
-                                           const ui::Event& event) {
-  // TODO(b/156258540): Add a "Need help?" button that links to a HC article.
-}
-
-views::LabelButton* AuthDialogContentsView::AddButton(const std::string& text,
-                                                      int id,
-                                                      views::View* container) {
-  // Creates a button with |text|.
-  auto button =
-      std::make_unique<views::MdTextButton>(this, base::ASCIIToUTF16(text));
-  button->SetID(id);
-
-  views::LabelButton* view = button.get();
-  container->AddChildView(
-      login_views_utils::WrapViewForPreferredSize(std::move(button)));
-  return view;
-}
-
 void AuthDialogContentsView::OnAuthSubmit(const base::string16& pin) {
   InSessionAuthDialogController::Get()->AuthenticateUserWithPin(
       base::UTF16ToUTF8(pin),

ash/in_session_auth/auth_dialog_contents_view.h

@@ -8,13 +8,11 @@
 #include <string>
 
 #include "ash/public/cpp/login_types.h"
-#include "ui/views/controls/button/button.h"
 #include "ui/views/view.h"
 
 namespace views {
 class BoxLayout;
 class Label;
-class LabelButton;
 }  // namespace views
 
 namespace ash {
@@ -24,8 +22,7 @@ class LoginPinView;
 
 // Contains the debug views that allows the developer to interact with the
 // AuthDialogController.
-class AuthDialogContentsView : public views::View,
-                               public views::ButtonListener {
+class AuthDialogContentsView : public views::View {
  public:
   // Flags which describe the set of currently visible auth methods.
   enum AuthMethods {
@@ -43,9 +40,6 @@ class AuthDialogContentsView : public views::View,
   // views::Views:
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
 
-  // views::ButtonListener:
-  void ButtonPressed(views::Button* sender, const ui::Event& event) override;
-
   uint32_t auth_methods() const { return auth_methods_; }
 
  private:
@@ -75,11 +69,6 @@ class AuthDialogContentsView : public views::View,
   // Add a view for action buttons.
   void AddActionButtonsView();
 
-  // Creates a button on the debug row that cannot be focused.
-  views::LabelButton* AddButton(const std::string& text,
-                                int id,
-                                views::View* container);
-
   // Called when the user submits password or PIN.
   void OnAuthSubmit(const base::string16& password);