Commit 58dac224 authored by elijahtaylor's avatar elijahtaylor Committed by Commit bot

Do not return a homepage URL for shared modules

This keeps the "Visit Website" link from showing up in chrome://extensions,
which makes sense because shared modules are automatically installed.

BUG=408927

Review URL: https://codereview.chromium.org/532973002

Cr-Commit-Position: refs/heads/master@{#293203}
parent ab2250a2
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include "extensions/common/manifest.h" #include "extensions/common/manifest.h"
#include "extensions/common/manifest_constants.h" #include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/permissions_parser.h" #include "extensions/common/manifest_handlers/permissions_parser.h"
#include "extensions/common/manifest_handlers/shared_module_info.h"
#include "extensions/common/permissions/api_permission.h" #include "extensions/common/permissions/api_permission.h"
#include "extensions/common/permissions/api_permission_set.h" #include "extensions/common/permissions/api_permission_set.h"
#include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util.h"
...@@ -56,9 +57,12 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) { ...@@ -56,9 +57,12 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) {
const GURL& homepage_url = GetManifestURL(extension, keys::kHomepageURL); const GURL& homepage_url = GetManifestURL(extension, keys::kHomepageURL);
if (homepage_url.is_valid()) if (homepage_url.is_valid())
return homepage_url; return homepage_url;
return UpdatesFromGallery(extension) ? bool use_webstore_url = UpdatesFromGallery(extension) &&
GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + extension->id()) : !SharedModuleInfo::IsSharedModule(extension);
GURL::EmptyGURL(); return use_webstore_url
? GURL(extension_urls::GetWebstoreItemDetailURLPrefix() +
extension->id())
: GURL::EmptyGURL();
} }
// static // static
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment