Commit 591db952 authored by benchan@chromium.org's avatar benchan@chromium.org

Minor clean up in DBusClient, DBusThreadManager, and FakeDBusThreadManager code.

BUG=None

Review URL: https://codereview.chromium.org/412433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285068 0039d316-1c4b-4281-b951-d872f2087c98
parent c7990dbf
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
namespace dbus { namespace dbus {
class Bus; class Bus;
}; } // namespace dbus
namespace chromeos { namespace chromeos {
......
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
#include "chromeos/dbus/dbus_thread_manager.h" #include "chromeos/dbus/dbus_thread_manager.h"
#include <map>
#include "base/command_line.h" #include "base/command_line.h"
#include "base/observer_list.h" #include "base/observer_list.h"
#include "base/sys_info.h" #include "base/sys_info.h"
...@@ -257,7 +255,7 @@ class DBusClientBundle { ...@@ -257,7 +255,7 @@ class DBusClientBundle {
// The DBusThreadManager implementation used in production. // The DBusThreadManager implementation used in production.
class DBusThreadManagerImpl : public DBusThreadManager { class DBusThreadManagerImpl : public DBusThreadManager {
public: public:
explicit DBusThreadManagerImpl() { DBusThreadManagerImpl() {
// Create the D-Bus thread. // Create the D-Bus thread.
base::Thread::Options thread_options; base::Thread::Options thread_options;
thread_options.message_loop_type = base::MessageLoop::TYPE_IO; thread_options.message_loop_type = base::MessageLoop::TYPE_IO;
...@@ -467,6 +465,8 @@ class DBusThreadManagerImpl : public DBusThreadManager { ...@@ -467,6 +465,8 @@ class DBusThreadManagerImpl : public DBusThreadManager {
scoped_refptr<dbus::Bus> system_bus_; scoped_refptr<dbus::Bus> system_bus_;
scoped_ptr<DBusClientBundle> client_bundle_; scoped_ptr<DBusClientBundle> client_bundle_;
scoped_ptr<PowerPolicyController> power_policy_controller_; scoped_ptr<PowerPolicyController> power_policy_controller_;
DISALLOW_COPY_AND_ASSIGN(DBusThreadManagerImpl);
}; };
// static // static
......
...@@ -5,8 +5,6 @@ ...@@ -5,8 +5,6 @@
#ifndef CHROMEOS_DBUS_DBUS_THREAD_MANAGER_H_ #ifndef CHROMEOS_DBUS_DBUS_THREAD_MANAGER_H_
#define CHROMEOS_DBUS_DBUS_THREAD_MANAGER_H_ #define CHROMEOS_DBUS_DBUS_THREAD_MANAGER_H_
#include <string>
#include "base/callback.h" #include "base/callback.h"
#include "base/memory/ref_counted.h" #include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h" #include "base/memory/scoped_ptr.h"
...@@ -14,12 +12,12 @@ ...@@ -14,12 +12,12 @@
namespace base { namespace base {
class Thread; class Thread;
}; } // namespace base
namespace dbus { namespace dbus {
class Bus; class Bus;
class ObjectPath; class ObjectPath;
}; } // namespace dbus
namespace chromeos { namespace chromeos {
......
...@@ -235,8 +235,7 @@ void FakeDBusThreadManager::SetShillProfileClient( ...@@ -235,8 +235,7 @@ void FakeDBusThreadManager::SetShillProfileClient(
shill_profile_client_ = client.Pass(); shill_profile_client_ = client.Pass();
} }
void FakeDBusThreadManager::SetGsmSMSClient( void FakeDBusThreadManager::SetGsmSMSClient(scoped_ptr<GsmSMSClient> client) {
scoped_ptr<GsmSMSClient> client) {
gsm_sms_client_ = client.Pass(); gsm_sms_client_ = client.Pass();
} }
...@@ -275,8 +274,7 @@ void FakeDBusThreadManager::SetNfcRecordClient( ...@@ -275,8 +274,7 @@ void FakeDBusThreadManager::SetNfcRecordClient(
nfc_record_client_ = client.Pass(); nfc_record_client_ = client.Pass();
} }
void FakeDBusThreadManager::SetNfcTagClient( void FakeDBusThreadManager::SetNfcTagClient(scoped_ptr<NfcTagClient> client) {
scoped_ptr<NfcTagClient> client) {
nfc_tag_client_ = client.Pass(); nfc_tag_client_ = client.Pass();
} }
...@@ -314,8 +312,7 @@ void FakeDBusThreadManager::SetUpdateEngineClient( ...@@ -314,8 +312,7 @@ void FakeDBusThreadManager::SetUpdateEngineClient(
update_engine_client_ = client.Pass(); update_engine_client_ = client.Pass();
} }
void FakeDBusThreadManager::AddObserver( void FakeDBusThreadManager::AddObserver(DBusThreadManagerObserver* observer) {
DBusThreadManagerObserver* observer) {
DCHECK(observer); DCHECK(observer);
observers_.AddObserver(observer); observers_.AddObserver(observer);
} }
...@@ -330,48 +327,45 @@ dbus::Bus* FakeDBusThreadManager::GetSystemBus() { ...@@ -330,48 +327,45 @@ dbus::Bus* FakeDBusThreadManager::GetSystemBus() {
return NULL; return NULL;
} }
BluetoothAdapterClient* BluetoothAdapterClient* FakeDBusThreadManager::GetBluetoothAdapterClient() {
FakeDBusThreadManager::GetBluetoothAdapterClient() {
return bluetooth_adapter_client_.get(); return bluetooth_adapter_client_.get();
} }
BluetoothAgentManagerClient* BluetoothAgentManagerClient*
FakeDBusThreadManager::GetBluetoothAgentManagerClient() { FakeDBusThreadManager::GetBluetoothAgentManagerClient() {
return bluetooth_agent_manager_client_.get(); return bluetooth_agent_manager_client_.get();
} }
BluetoothDeviceClient* BluetoothDeviceClient* FakeDBusThreadManager::GetBluetoothDeviceClient() {
FakeDBusThreadManager::GetBluetoothDeviceClient() {
return bluetooth_device_client_.get(); return bluetooth_device_client_.get();
} }
BluetoothGattCharacteristicClient* BluetoothGattCharacteristicClient*
FakeDBusThreadManager::GetBluetoothGattCharacteristicClient() { FakeDBusThreadManager::GetBluetoothGattCharacteristicClient() {
return bluetooth_gatt_characteristic_client_.get(); return bluetooth_gatt_characteristic_client_.get();
} }
BluetoothGattDescriptorClient* BluetoothGattDescriptorClient*
FakeDBusThreadManager::GetBluetoothGattDescriptorClient() { FakeDBusThreadManager::GetBluetoothGattDescriptorClient() {
return bluetooth_gatt_descriptor_client_.get(); return bluetooth_gatt_descriptor_client_.get();
} }
BluetoothGattManagerClient* BluetoothGattManagerClient*
FakeDBusThreadManager::GetBluetoothGattManagerClient() { FakeDBusThreadManager::GetBluetoothGattManagerClient() {
return bluetooth_gatt_manager_client_.get(); return bluetooth_gatt_manager_client_.get();
} }
BluetoothGattServiceClient* BluetoothGattServiceClient*
FakeDBusThreadManager::GetBluetoothGattServiceClient() { FakeDBusThreadManager::GetBluetoothGattServiceClient() {
return bluetooth_gatt_service_client_.get(); return bluetooth_gatt_service_client_.get();
} }
BluetoothInputClient* BluetoothInputClient* FakeDBusThreadManager::GetBluetoothInputClient() {
FakeDBusThreadManager::GetBluetoothInputClient() {
return bluetooth_input_client_.get(); return bluetooth_input_client_.get();
} }
BluetoothProfileManagerClient* BluetoothProfileManagerClient*
FakeDBusThreadManager::GetBluetoothProfileManagerClient() { FakeDBusThreadManager::GetBluetoothProfileManagerClient() {
return bluetooth_profile_manager_client_.get(); return bluetooth_profile_manager_client_.get();
} }
...@@ -395,28 +389,23 @@ LorgnetteManagerClient* FakeDBusThreadManager::GetLorgnetteManagerClient() { ...@@ -395,28 +389,23 @@ LorgnetteManagerClient* FakeDBusThreadManager::GetLorgnetteManagerClient() {
return lorgnette_manager_client_.get(); return lorgnette_manager_client_.get();
} }
ShillDeviceClient* ShillDeviceClient* FakeDBusThreadManager::GetShillDeviceClient() {
FakeDBusThreadManager::GetShillDeviceClient() {
return shill_device_client_.get(); return shill_device_client_.get();
} }
ShillIPConfigClient* ShillIPConfigClient* FakeDBusThreadManager::GetShillIPConfigClient() {
FakeDBusThreadManager::GetShillIPConfigClient() {
return shill_ipconfig_client_.get(); return shill_ipconfig_client_.get();
} }
ShillManagerClient* ShillManagerClient* FakeDBusThreadManager::GetShillManagerClient() {
FakeDBusThreadManager::GetShillManagerClient() {
return shill_manager_client_.get(); return shill_manager_client_.get();
} }
ShillProfileClient* ShillProfileClient* FakeDBusThreadManager::GetShillProfileClient() {
FakeDBusThreadManager::GetShillProfileClient() {
return shill_profile_client_.get(); return shill_profile_client_.get();
} }
ShillServiceClient* ShillServiceClient* FakeDBusThreadManager::GetShillServiceClient() {
FakeDBusThreadManager::GetShillServiceClient() {
return shill_service_client_.get(); return shill_service_client_.get();
} }
...@@ -428,13 +417,11 @@ ImageBurnerClient* FakeDBusThreadManager::GetImageBurnerClient() { ...@@ -428,13 +417,11 @@ ImageBurnerClient* FakeDBusThreadManager::GetImageBurnerClient() {
return image_burner_client_.get(); return image_burner_client_.get();
} }
IntrospectableClient* IntrospectableClient* FakeDBusThreadManager::GetIntrospectableClient() {
FakeDBusThreadManager::GetIntrospectableClient() {
return introspectable_client_.get(); return introspectable_client_.get();
} }
ModemMessagingClient* ModemMessagingClient* FakeDBusThreadManager::GetModemMessagingClient() {
FakeDBusThreadManager::GetModemMessagingClient() {
return modem_messaging_client_.get(); return modem_messaging_client_.get();
} }
...@@ -458,8 +445,7 @@ NfcRecordClient* FakeDBusThreadManager::GetNfcRecordClient() { ...@@ -458,8 +445,7 @@ NfcRecordClient* FakeDBusThreadManager::GetNfcRecordClient() {
return nfc_record_client_.get(); return nfc_record_client_.get();
} }
PermissionBrokerClient* PermissionBrokerClient* FakeDBusThreadManager::GetPermissionBrokerClient() {
FakeDBusThreadManager::GetPermissionBrokerClient() {
return permission_broker_client_.get(); return permission_broker_client_.get();
} }
...@@ -467,13 +453,11 @@ PowerManagerClient* FakeDBusThreadManager::GetPowerManagerClient() { ...@@ -467,13 +453,11 @@ PowerManagerClient* FakeDBusThreadManager::GetPowerManagerClient() {
return power_manager_client_.get(); return power_manager_client_.get();
} }
PowerPolicyController* PowerPolicyController* FakeDBusThreadManager::GetPowerPolicyController() {
FakeDBusThreadManager::GetPowerPolicyController() {
return power_policy_controller_.get(); return power_policy_controller_.get();
} }
SessionManagerClient* SessionManagerClient* FakeDBusThreadManager::GetSessionManagerClient() {
FakeDBusThreadManager::GetSessionManagerClient() {
return session_manager_client_.get(); return session_manager_client_.get();
} }
......
...@@ -5,8 +5,6 @@ ...@@ -5,8 +5,6 @@
#ifndef CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_ #ifndef CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_
#define CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_ #define CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_
#include <string>
#include "base/logging.h" #include "base/logging.h"
#include "base/observer_list.h" #include "base/observer_list.h"
#include "chromeos/chromeos_export.h" #include "chromeos/chromeos_export.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment