Commit 59359a52 authored by Tom Anderson's avatar Tom Anderson Committed by Thomas Anderson

Temporarily disable layout test changes

This is necessary in order to land CL [1].  I've been trying for a few weeks to
land it, but there's always new merge conflicts due to changed layout test
baselines.  This CL bans changes in third_party/WebKit/LayoutTests for a few
hours while I rebase and land CL [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/976083

BUG=787020
R=dpranke

Change-Id: I24bf199e20e5d5da1fc84e1ac8e64320213527d0
Reviewed-on: https://chromium-review.googlesource.com/996633Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548236}
parent 5b8a06be
......@@ -2711,6 +2711,27 @@ def _CheckWATCHLISTS(input_api, output_api):
return []
def _CheckNoLayoutTestChanges(input_api, output_api):
changed_layout_test_files = []
layout_tests_pattern = input_api.re.compile(
r'^third_party[\\\/]WebKit[\\\/]LayoutTests[\\\/].*')
for f in input_api.AffectedFiles(include_deletes=True):
local_path = f.LocalPath()
if input_api.re.match(layout_tests_pattern, local_path):
changed_layout_test_files.append(local_path)
if changed_layout_test_files == []:
return []
return [output_api.PresubmitError(
'Layout test changes are temporarily disabled by thomasanderson@.\n'
'They will be allowed once again when CL [1] lands.\n'
'If CL [1] does not land by 9pm PST, please feel free to revert the CL\n'
'that adds this PRESUBMIT check (CL [2]).\n'
'[1] https://chromium-review.googlesource.com/c/chromium/src/+/976083\n'
'[2] https://chromium-review.googlesource.com/c/chromium/src/+/996633\n'
'Changed layout test files:\n' +
'\n'.join(changed_layout_test_files))]
def _AndroidSpecificOnUploadChecks(input_api, output_api):
"""Groups checks that target android code."""
results = []
......@@ -2786,6 +2807,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckWATCHLISTS(input_api, output_api))
results.extend(input_api.RunTests(
input_api.canned_checks.CheckVPythonSpec(input_api, output_api)))
results.extend(_CheckNoLayoutTestChanges(input_api, output_api))
for f in input_api.AffectedFiles():
path, name = input_api.os_path.split(f.LocalPath())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment