Commit 593aa15e authored by Daniel Clark's avatar Daniel Clark Committed by Commit Bot

Add 'max' attribute to month-picker-appearance-step.html to prevent 'This...

Add 'max' attribute to month-picker-appearance-step.html to prevent 'This month' button from toggling

The month picker's 'This month' button is grayed out if the current
month (the actual month it is right now, not the 'value' attribute
of the control) is a valid choice as determined by the value, min,
max, and step attributes. August 2020 is the first month since this
test was introduced that is valid per the combination of value and
step of the control in this test, so it started failing at the
beginning of the month as the button was no longer grayed out.

This change re-enables the test, adding a 'max' attribute with a
value in the past, so that the button will always be grayed out
going forward.

The baselines still need to be regenerated because it turns out
that adding a max changes the width of the control's text field.
See blink::DateTimeNumericFieldElement::MaximumWidth and the
reference to it in
blink::DateTimeEditElement::CustomStyleForLayoutObject.

Bug: 1112111
Change-Id: I70cce1b98114c888a701e067d0543b7d12e2f457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337099Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#794768}
parent e4c3791b
......@@ -6851,9 +6851,6 @@ crbug.com/1111287 http/tests/devtools/sources/debugger-breakpoints/breakpoint-wi
crbug.com/1111410 http/tests/serviceworker/service-worker-gc.html [ Pass Failure ]
# Sheriff 2020-08-01
crbug.com/1112111 fast/forms/month/month-picker-appearance-step.html [ Pass Failure ]
# Sheriff 2020-08-03
crbug.com/1108423 external/wpt/referrer-policy/gen/worker-classic.http-rp/unset/worker-classic.http.html [ Pass Timeout ]
crbug.com/1106429 virtual/percent-based-scrolling/max-percent-delta-page-zoom.html [ Pass Failure ]
......
......@@ -3,7 +3,7 @@
testRunner.waitUntilDone();
</script>
<script src="../../../fast/forms/resources/picker-common.js"></script>
<input type=month id=month value="2019-08" step="3">
<input type="month" id="month" value="2019-08" step="3" max="2020-01">
<script>
openPicker(document.getElementById('month'), () => testRunner.notifyDone());
</script>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment