Commit 593f72ca authored by Marijn Kruisselbrink's avatar Marijn Kruisselbrink Committed by Commit Bot

Minor fixes in ChooserContextBase.

Fix one comment to not mention non-existing methods, and change a
parameter from a non-const reference to a const reference, as I
assume it was supposed to be.

Bug: None
Change-Id: I38d6cef800958dc0c4cf22af16e2cb2a9e4f58ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231543
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775285}
parent ab465aaf
...@@ -156,7 +156,7 @@ void ChooserContextBase::GrantObjectPermission( ...@@ -156,7 +156,7 @@ void ChooserContextBase::GrantObjectPermission(
void ChooserContextBase::UpdateObjectPermission( void ChooserContextBase::UpdateObjectPermission(
const url::Origin& requesting_origin, const url::Origin& requesting_origin,
const url::Origin& embedding_origin, const url::Origin& embedding_origin,
base::Value& old_object, const base::Value& old_object,
base::Value new_object) { base::Value new_object) {
base::Value setting = base::Value setting =
GetWebsiteSetting(requesting_origin, embedding_origin, /*info=*/nullptr); GetWebsiteSetting(requesting_origin, embedding_origin, /*info=*/nullptr);
......
...@@ -105,14 +105,14 @@ class ChooserContextBase : public KeyedService { ...@@ -105,14 +105,14 @@ class ChooserContextBase : public KeyedService {
// |host_content_settings_map_|. // |host_content_settings_map_|.
void UpdateObjectPermission(const url::Origin& requesting_origin, void UpdateObjectPermission(const url::Origin& requesting_origin,
const url::Origin& embedding_origin, const url::Origin& embedding_origin,
base::Value& old_object, const base::Value& old_object,
base::Value new_object); base::Value new_object);
// Revokes |requesting_origin|'s permission to access |object| when embedded // Revokes |requesting_origin|'s permission to access |object| when embedded
// within |embedding_origin|. // within |embedding_origin|.
// //
// This method may be extended by a subclass to revoke permission to access // This method may be extended by a subclass to revoke permission to access
// objects returned by GetPreviouslyChosenObjects but not stored in // objects returned by GetGrantedObjects but not stored in
// |host_content_settings_map_|. // |host_content_settings_map_|.
virtual void RevokeObjectPermission(const url::Origin& requesting_origin, virtual void RevokeObjectPermission(const url::Origin& requesting_origin,
const url::Origin& embedding_origin, const url::Origin& embedding_origin,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment