Commit 5946024f authored by Aaron Colwell's avatar Aaron Colwell Committed by Commit Bot

Adjust ~BrowserContext crashkey size and shorten field names.

Increasing the max size of the crashkey value and shortening the field
names used in the crashkey value so that more information can be stored
in it. The current values were accidentally made too small and initial
crash reports contain incomplete information as a result.

Bug: 1099998
Change-Id: I66c29113764b098e2fd100451d613fd1ea195860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339715
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795113}
parent 6d58cae4
...@@ -493,15 +493,14 @@ BrowserContext::~BrowserContext() { ...@@ -493,15 +493,14 @@ BrowserContext::~BrowserContext() {
if (host->GetBrowserContext() == this) { if (host->GetBrowserContext() == this) {
rph_crash_key_value += "{"; rph_crash_key_value += "{";
rph_crash_key_value += " process_lock='" + rph_crash_key_value +=
policy->GetProcessLock(host->GetID()).ToString() + " pl='" + policy->GetProcessLock(host->GetID()).ToString() + "'";
"'";
if (host->HostHasNotBeenUsed()) if (host->HostHasNotBeenUsed())
rph_crash_key_value += " has_not_been_used "; rph_crash_key_value += " hnbu";
if (RenderProcessHostImpl::IsSpareProcessForCrashReporting(host)) if (RenderProcessHostImpl::IsSpareProcessForCrashReporting(host))
rph_crash_key_value += " is_spare"; rph_crash_key_value += " spr";
rph_crash_key_value += " }"; rph_crash_key_value += " }";
} }
...@@ -510,7 +509,7 @@ BrowserContext::~BrowserContext() { ...@@ -510,7 +509,7 @@ BrowserContext::~BrowserContext() {
NOTREACHED() << "rph_with_bc_reference : " << rph_crash_key_value; NOTREACHED() << "rph_with_bc_reference : " << rph_crash_key_value;
static auto* crash_key = base::debug::AllocateCrashKeyString( static auto* crash_key = base::debug::AllocateCrashKeyString(
"rph_with_bc_reference", base::debug::CrashKeySize::Size32); "rph_with_bc_reference", base::debug::CrashKeySize::Size256);
base::debug::ScopedCrashKeyString auto_clear(crash_key, base::debug::ScopedCrashKeyString auto_clear(crash_key,
rph_crash_key_value); rph_crash_key_value);
base::debug::DumpWithoutCrashing(); base::debug::DumpWithoutCrashing();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment