Commit 5986a0e0 authored by Tommy Steimel's avatar Tommy Steimel Committed by Commit Bot

Fix gn check issues for chrome/browser/thumbnail/*

This CL adds the necessary deps to chrome/browser/thumbnail/* to pass
`gn check`, which was previously failing on Android configs.

Bug: 1105848
Change-Id: Iecfd7c46dd7efe46e4f80a23042f7f2ee7a68bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300219Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788670}
parent 90515305
......@@ -70,8 +70,6 @@ no_check_targets = [
"//chrome/browser/safety_check/android:*", # 3 errors
"//chrome/browser/share:*", # 7 errors
"//chrome/browser/storage_access_api:*", # 2 errors
"//chrome/browser/thumbnail/cc:*", # 4 errors
"//chrome/browser/thumbnail/generator:*", # 2 errors
"//chrome/browser/touch_to_fill/android:*", # 8 errors
"//chrome/browser/touch_to_fill:*", # 5 errors
"//chrome/browser/updates/announcement_notification:*", # 15 errors
......@@ -122,7 +120,8 @@ no_check_targets = [
"//extensions/browser/api/crash_report_private:*", # 1 error
"//extensions/browser/api/declarative:*", # 20 errors
"//extensions/browser/api/declarative_content:*", # 2 errors
"//extensions/browser/api/declarative_net_request/filter_list_converter:*", # 1 error
"//extensions/browser/api/declarative_net_request/filter_list_converter:*", # 1
# error
"//extensions/browser/api/declarative_net_request:*", # 18 errors
"//extensions/browser/api/declarative_webrequest:*", # 29 errors
"//extensions/browser/api/diagnostics:*", # 2 errors
......
......@@ -30,6 +30,13 @@ source_set("cc") {
"thumbnail_cache.cc",
"thumbnail_cache.h",
]
if (is_android) {
deps += [
"//third_party/android_opengl/etc1",
"//ui/android",
]
}
}
source_set("unit_tests") {
......
......@@ -49,6 +49,8 @@ source_set("generator") {
"android/thumbnail_media_parser_impl.cc",
"android/thumbnail_media_parser_impl.h",
]
deps += [ "//services/viz/public/cpp/gpu" ]
} else {
sources += [
"android/noop_thumbnail_media_parser.cc",
......@@ -58,6 +60,7 @@ source_set("generator") {
deps += [
":jni_headers",
"//media/mojo/clients",
"//third_party/android_opengl/etc1",
]
}
......
......@@ -23,6 +23,8 @@ jumbo_source_set("clients") {
"//chrome/browser:*",
"//chrome/browser/thumbnail/generator",
"//content/gpu:*",
# TODO(liberato): can we avoid this?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment