Skip to content

GitLab

T
tangled
Commit 59a3f8c6 authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot
Browse files
Options

Fix emphasis-overlap.html not to rely on crbug.com/40634 

fast/text/emphasis-overlap.html fails in LayoutNG because
what it is testing works correctly, but LayoutNG fixed
crbug.com/40634 and that difference caused pixels to fail.

This patch removes dependency to crbug.com/40634 behavior
from the test, and hence it passes in LayoutNG.

The behavior of crbug.com/40634 is now split to
wpt/css/css-text/white-space/trailing-space-before-br-001.html
in r570744 (CL:1116622).

TBR=eae@chromium.org

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8acfa36f83bac02ae71bd8907e733f05ecf359fe
Reviewed-on: https://chromium-review.googlesource.com/1116511Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570766}
parent 5d32ca17
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 2 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
View file @ 59a3f8c6
......@@ -526,7 +526,6 @@ crbug.com/591099 fast/text/ellipsis-in-relative-inline-right.html [ Failure ]
crbug.com/591099 fast/text/ellipsis-in-relative-inline.html [ Failure ]
crbug.com/714962 fast/text/emoticons.html [ Failure ]
crbug.com/591099 fast/text/emphasis-combined-text.html [ Failure ]
crbug.com/591099 fast/text/emphasis-overlap.html [ Failure ]
crbug.com/591099 fast/text/hide-atomic-inlines-after-ellipsis.html [ Failure ]
crbug.com/796943 fast/text/international/shape-across-elements-simple.html [ Pass ]
crbug.com/591099 fast/text/international/text-combine-image-test.html [ Failure ]
......
third_party/WebKit/LayoutTests/fast/text/emphasis-overlap.html
View file @ 59a3f8c6
<!DOCTYPE html>
<script src="../../resources/ahem.js"></script>
<style>
div div { font-family: Ahem; font-size: 32px; -webkit-font-smoothing: none; display: inline-block; margin: 8px 0; }
div div {
font-family: Ahem;
font-size: 32px;
-webkit-font-smoothing: none;
display: inline-block;
margin: 8px 0;
inline-size: 4em;
}
.flipped { writing-mode: vertical-rl; }
div.flipped div { display: block; margin:0 8px 0 0; }
.over { color: blue; -webkit-text-emphasis: "m"; -webkit-text-emphasis-position: over right; }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment