Commit 59d46f2e authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

Further attempt to fix ServiceWorkerBrowserTest flakiness

crrev.com/c/2467037 added a speculative fix for flakiness but it
seems the flakiness still exists. This CL makes further attempt to
de-flake ServiceWorkerBrowserTest by adding RunAllTasksUntilIdle()
in TearDownOnMainThread().

Bug: 1142544
Change-Id: I166dc33f952c3da09b36e7156ebb19a638247732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500649Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821140}
parent d18b40f0
...@@ -360,6 +360,7 @@ class ServiceWorkerBrowserTest : public ContentBrowserTest { ...@@ -360,6 +360,7 @@ class ServiceWorkerBrowserTest : public ContentBrowserTest {
RunOnCoreThread(base::BindOnce(&self::TearDownOnCoreThread, RunOnCoreThread(base::BindOnce(&self::TearDownOnCoreThread,
base::Unretained(this), loop.QuitClosure())); base::Unretained(this), loop.QuitClosure()));
loop.Run(); loop.Run();
content::RunAllTasksUntilIdle();
wrapper_ = nullptr; wrapper_ = nullptr;
} }
...@@ -599,14 +600,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, FetchPageWithSaveData) { ...@@ -599,14 +600,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, FetchPageWithSaveData) {
// Tests that when data saver is enabled and a cross-origin fetch by a webpage // Tests that when data saver is enabled and a cross-origin fetch by a webpage
// is intercepted by a serviceworker, and the serviceworker does a fetch, the // is intercepted by a serviceworker, and the serviceworker does a fetch, the
// preflight request does not have save-data in Access-Control-Request-Headers. // preflight request does not have save-data in Access-Control-Request-Headers.
#if defined(OS_ANDROID) IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, CrossOriginFetchWithSaveData) {
// Flaky on Android, http://crbug.com/1142544.
#define MAYBE_CrossOriginFetchWithSaveData DISABLED_CrossOriginFetchWithSaveData
#else
#define MAYBE_CrossOriginFetchWithSaveData CrossOriginFetchWithSaveData
#endif
IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest,
MAYBE_CrossOriginFetchWithSaveData) {
StartServerAndNavigateToSetup(); StartServerAndNavigateToSetup();
const char kPageUrl[] = "/service_worker/fetch_cross_origin.html"; const char kPageUrl[] = "/service_worker/fetch_cross_origin.html";
const char kWorkerUrl[] = "/service_worker/fetch_event_pass_through.js"; const char kWorkerUrl[] = "/service_worker/fetch_event_pass_through.js";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment