2011-03-16 Alexis Menard <alexis.menard@openbossa.org>

        Reviewed by Martin Robinson.

        [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
        https://bugs.webkit.org/show_bug.cgi?id=56403

        In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
        As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
        i.e the pause() made when beginScrubbing is done is just internal.

        No new tests: Verified manually.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):

git-svn-id: svn://svn.chromium.org/blink/trunk@81234 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent a1a9d431
2011-03-16 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Martin Robinson.
[GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
https://bugs.webkit.org/show_bug.cgi?id=56403
In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
i.e the pause() made when beginScrubbing is done is just internal.
No new tests: Verified manually.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
2011-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
......
......@@ -1064,15 +1064,9 @@ void MediaPlayerPrivateGStreamer::updateStates()
if (!m_isStreaming && !m_buffering)
return;
// Resume playback if a seek was performed in a live pipeline
// or during progressive download. That second use-case
// happens when the seek is performed to a region of the media
// that hasn't been downloaded yet.
if (m_seeking) {
shouldUpdateAfterSeek = true;
m_seeking = false;
if (m_paused)
gst_element_set_state(m_playBin, GST_STATE_PLAYING);
}
break;
case GST_STATE_CHANGE_FAILURE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment