Commit 59e15bbc authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Fix typos while reading the code.

No code change.

R=ssid@chromium.org

Change-Id: I7eaef6cab924fb60dd7b242d333276dce83522aa
Reviewed-on: https://chromium-review.googlesource.com/1191327Reviewed-by: default avatarSiddhartha S <ssid@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586358}
parent b622e9b5
...@@ -123,7 +123,7 @@ struct HandlerParams { ...@@ -123,7 +123,7 @@ struct HandlerParams {
AsyncSafeWaitableEvent* event; AsyncSafeWaitableEvent* event;
// Return values: // Return values:
// Succesfully copied the stack segment. // Successfully copied the stack segment.
bool* success; bool* success;
// The register context of the thread used by libunwind. // The register context of the thread used by libunwind.
unw_context_t* context; unw_context_t* context;
...@@ -139,10 +139,10 @@ struct HandlerParams { ...@@ -139,10 +139,10 @@ struct HandlerParams {
base::subtle::AtomicWord g_handler_params; base::subtle::AtomicWord g_handler_params;
// The signal handler is called on the stopped thread as an additional stack // The signal handler is called on the stopped thread as an additional stack
// frame. This relies on no alternate sigalstack() being set. This function // frame. This relies on no alternate signalstack() being set. This function
// skips the handler frame on stack and unwinds the rest of the stack frames. // skips the handler frame on stack and unwinds the rest of the stack frames.
// This function should use async-safe functions only. The only call that could // This function should use async-safe functions only. The only call that could
// allocte memory on heap would be the cache in cfi unwinder. We need to ensure // allocate memory on heap would be the cache in cfi unwinder. We need to ensure
// that AllocateCacheForCurrentThread() is called on the stopped thread before // that AllocateCacheForCurrentThread() is called on the stopped thread before
// trying to get stack trace from the thread. See // trying to get stack trace from the thread. See
// https://www.gnu.org/software/libc/manual/html_node/Nonreentrancy.html#Nonreentrancy. // https://www.gnu.org/software/libc/manual/html_node/Nonreentrancy.html#Nonreentrancy.
...@@ -196,7 +196,7 @@ __wrap_dl_unwind_find_exidx(_Unwind_Ptr pc, int* length) { ...@@ -196,7 +196,7 @@ __wrap_dl_unwind_find_exidx(_Unwind_Ptr pc, int* length) {
// 0x80000000 has high bit set to 1. This means the unwind data is inline and // 0x80000000 has high bit set to 1. This means the unwind data is inline and
// not in exception table (section 5 EHABI). 0 on the second high byte causes // not in exception table (section 5 EHABI). 0 on the second high byte causes
// a 0 proceedure to be lsda. But this is never executed since the pc and sp // a 0 proceedure to be lsda. But this is never executed since the pc and sp
// will be overriden, before calling unw_step. // will be overridden, before calling unw_step.
static const FakeExidx chrome_exidx_data[] = { static const FakeExidx chrome_exidx_data[] = {
{CFIBacktraceAndroid::executable_start_addr(), 0x80000000}, {CFIBacktraceAndroid::executable_start_addr(), 0x80000000},
{CFIBacktraceAndroid::executable_end_addr(), 0x80000000}}; {CFIBacktraceAndroid::executable_end_addr(), 0x80000000}};
......
...@@ -21,7 +21,7 @@ class TRACING_EXPORT StackUnwinderAndroid { ...@@ -21,7 +21,7 @@ class TRACING_EXPORT StackUnwinderAndroid {
public: public:
static StackUnwinderAndroid* GetInstance(); static StackUnwinderAndroid* GetInstance();
// Intializes the unwinder for current process. It finds all loaded libraries // Initializes the unwinder for current process. It finds all loaded libraries
// in current process and also initializes CFIBacktraceAndroid, with file IO. // in current process and also initializes CFIBacktraceAndroid, with file IO.
void Initialize(); void Initialize();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment