Skip to content

GitLab

T
tangled
Commit 59ec01bd authored by Dave Schuyler's avatar Dave Schuyler Committed by Commit Bot
Browse files
Options

[i18n] remove i18n-content from domain-reliability-internals 

This CL removes the i18n-content on the <title> (afaik it was not being
set so I removed it rather than converting to $i18n{title}). Also removes
strings.js and i18n_template.js which should be unneeded at this point.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iab29f07c23d200ed824f4207199853d982eefff2
Reviewed-on: https://chromium-review.googlesource.com/585769Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491143}
parent b654d193
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
chrome/browser/resources/domain_reliability_internals.html
View file @ 59ec01bd
...@@ -2,17 +2,14 @@ ...@@ -2,17 +2,14 @@
<html dir="$i18n{textdirection}" lang="$i18n{language}"> <html dir="$i18n{textdirection}" lang="$i18n{language}">
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<title i18n-content="title"></title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
<link rel="stylesheet" href="domain_reliability_internals.css" /> <link rel="stylesheet" href="domain_reliability_internals.css" />
<script src="chrome://resources/js/cr.js"></script> <script src="chrome://resources/js/cr.js"></script>
<script src="chrome://resources/js/util.js"></script> <script src="chrome://resources/js/util.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script> <script src="chrome://resources/js/jstemplate_compiled.js"></script>
<script src="strings.js"></script>
<script src="domain_reliability_internals.js"></script> <script src="domain_reliability_internals.js"></script>
</head> </head>
<body> <body>
<script src="chrome://resources/js/i18n_template.js"></script>
<div id="template"> <div id="template">
<div jsdisplay="error"> <div jsdisplay="error">
Error loading Domain Reliability data: Error loading Domain Reliability data:
......
chrome/browser/ui/webui/domain_reliability_internals_ui.cc
View file @ 59ec01bd
...@@ -4,6 +4,9 @@ ...@@ -4,6 +4,9 @@
#include "chrome/browser/ui/webui/domain_reliability_internals_ui.h" #include "chrome/browser/ui/webui/domain_reliability_internals_ui.h"
#include <string>
#include <unordered_set>
#include "chrome/browser/domain_reliability/service_factory.h" #include "chrome/browser/domain_reliability/service_factory.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/common/url_constants.h" #include "chrome/common/url_constants.h"
...@@ -20,7 +23,6 @@ DomainReliabilityInternalsUI::DomainReliabilityInternalsUI( ...@@ -20,7 +23,6 @@ DomainReliabilityInternalsUI::DomainReliabilityInternalsUI(
: content::WebUIController(web_ui) { : content::WebUIController(web_ui) {
content::WebUIDataSource* html_source = content::WebUIDataSource::Create( content::WebUIDataSource* html_source = content::WebUIDataSource::Create(
chrome::kChromeUIDomainReliabilityInternalsHost); chrome::kChromeUIDomainReliabilityInternalsHost);
html_source->SetJsonPath("strings.js");
html_source->AddResourcePath("domain_reliability_internals.css", html_source->AddResourcePath("domain_reliability_internals.css",
IDR_DOMAIN_RELIABILITY_INTERNALS_CSS); IDR_DOMAIN_RELIABILITY_INTERNALS_CSS);
html_source->AddResourcePath("domain_reliability_internals.js", html_source->AddResourcePath("domain_reliability_internals.js",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment