Commit 59fd2263 authored by Zhongyi Shi's avatar Zhongyi Shi Committed by Commit Bot

Add two histograms for new connection on alternate network.

- Net.QuicStreamFactory.AttemptMigrationBeforeHandshake.FailedConnectionType
tracks the connection type of the default network when the original
connection fails with handshake not confirmed.
- Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType
tracks the connection type of the altenate network when the original
connection fails with handshake not confirmed and a new connection is
about to be retried on the alternate network.

These histograms may give us hints why the altenate network is not
availabe when the connection on the default network fails. Current
theory is that the default network is on Cellular, and there is no
alternate network.

Bug: 790547
Change-Id: Ibfd63efed9a1b72b7d6de95453af55feacd9cef6
Reviewed-on: https://chromium-review.googlesource.com/c/1354320Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612414}
parent 7a56a3bb
......@@ -795,7 +795,17 @@ int QuicStreamFactory::Job::DoConfirmConnection(int rv) {
UMA_HISTOGRAM_BOOLEAN(
"Net.QuicStreamFactory.AttemptMigrationBeforeHandshake",
connection_retried_);
UMA_HISTOGRAM_ENUMERATION(
"Net.QuicStreamFactory.AttemptMigrationBeforeHandshake."
"FailedConnectionType",
NetworkChangeNotifier::GetNetworkConnectionType(
factory_->default_network()),
NetworkChangeNotifier::ConnectionType::CONNECTION_LAST + 1);
if (connection_retried_) {
UMA_HISTOGRAM_ENUMERATION(
"Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType",
NetworkChangeNotifier::GetNetworkConnectionType(network_),
NetworkChangeNotifier::ConnectionType::CONNECTION_LAST + 1);
net_log_.AddEvent(
NetLogEventType::
QUIC_STREAM_FACTORY_JOB_RETRY_ON_ALTERNATE_NETWORK);
......
......@@ -61371,6 +61371,16 @@ uploading your change for review.
</summary>
</histogram>
<histogram
name="Net.QuicStreamFactory.AttemptMigrationBeforeHandshake.FailedConnectionType"
enum="NetworkConnectionType" expires_after="2020-12-01">
<owner>zhongyi@chromium.org</owner>
<summary>
Connection type of the default network when the connection fails with
handshake not confirmed.
</summary>
</histogram>
<histogram name="Net.QuicStreamFactory.BadPacketLossEvents5"
enum="QuicBadPacketLossEvents">
<owner>rch@chromium.org</owner>
......@@ -61423,6 +61433,17 @@ uploading your change for review.
</summary>
</histogram>
<histogram
name="Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType"
enum="NetworkConnectionType" expires_after="2020-12-01">
<owner>zhongyi@chromium.org</owner>
<summary>
Connection type of the alternate network when a connection is about to be
attempted when the original connection fails on the default network with
handshake not confirmed.
</summary>
</histogram>
<histogram name="Net.QuicStreamFactory.MigrationBeforeHandshake2"
enum="BooleanSuccess" expires_after="2020-12-01">
<owner>zhongyi@chromium.org</owner>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment